Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341219 - [MPE] MultiPageEditorSite may not end up forwarding post selection events
Summary: [MPE] MultiPageEditorSite may not end up forwarding post selection events
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Remy Suen CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 08:18 EDT by Remy Suen CLA
Modified: 2011-10-04 12:38 EDT (History)
2 users (show)

See Also:

Attachments
MultiPageEditorSite patch v1 (12.07 KB, patch)
2011-03-31 09:10 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-03-29 08:18:33 EDT 
If an inner editor of an MPEP doesn't actually implement IPSP, no post selection events are fired even though MultiPageSelectionProvider implements the IPSP interface.
Comment 1 Remy Suen CLA 2011-03-31 09:10:06 EDT 
Created attachment 192269 [details]
MultiPageEditorSite patch v1

Patch with tests to verify that post selection events are fired and that the 'Properties' view reacts to the MPEP's inner editor's selection.
Comment 2 Remy Suen CLA 2011-03-31 09:10:49 EDT 
Fixed in CVS HEAD.
Comment 3 Dani Megert CLA 2011-03-31 10:07:15 EDT 
Looks good!
Comment 4 Remy Suen CLA 2011-04-26 07:55:49 EDT 
Verified with I20110425-1800 on Windows XP.
Comment 5 Dani Megert CLA 2011-10-04 12:38:47 EDT 
This didn't make it into the 4.x stream. Cherry-picked now:
Commit a5e52d50b8b26e06ea3be32dde1536a4c32e7d69