Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341102 - Wrong license text for SDK
Summary: Wrong license text for SDK
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.1 M7   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 09:26 EDT by John Arthorne CLA
Modified: 2011-04-18 13:37 EDT (History)
2 users (show)

See Also:

Attachments
Screen shot (75.43 KB, image/png)
2011-03-28 09:27 EDT, John Arthorne CLA 		no flags Details
patch for e4.rcp feature (73.15 KB, patch)
2011-03-29 19:36 EDT, Kim Moir CLA 		no flags Details | Diff
patch for 3.7 builder's product files (9.64 KB, patch)
2011-04-08 15:13 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-03-28 09:26:56 EDT 
Build: I20110322

When upgrading to this build, I was presented with two different copies of the Eclipse SUA. It looks like the SDK feature has the old license text.
Comment 1 John Arthorne CLA 2011-03-28 09:27:23 EDT 
Created attachment 192001 [details]
Screen shot
Comment 2 Kim Moir CLA 2011-03-29 18:06:40 EDT 
The features with the old license are 
org.eclipse.e4.rcp and org.eclipse.e4.rcp.source

I'll attach a patch for those

I also noticed that emf.common and emf.core also have the old license.
Comment 3 Kim Moir CLA 2011-03-29 19:36:39 EDT 
Created attachment 192150 [details]
patch for e4.rcp feature
Comment 4 Kim Moir CLA 2011-03-29 19:52:41 EDT 
Andrew, do you want to review this patch or should I just release it?
Comment 5 Andrew Niefer CLA 2011-03-30 12:11:06 EDT 
Kim,
It looks like the org.eclipse.e4.rcp feature actually needs to be updated to use the shared licensing stuff.

I think John is seeing a seperate issue, there is a license in org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk/builder/sdk.product
 and the other .product files, and this is what he is seeing in the screenshot.  This affects both 3.7 and 4.1
Comment 6 Kim Moir CLA 2011-03-31 07:25:48 EDT 
Thanks Andrew, I'll attach patches for the builder for these issues.
Comment 7 Kim Moir CLA 2011-04-08 15:13:21 EDT 
Created attachment 192873 [details]
patch for 3.7 builder's product files
Comment 8 Kim Moir CLA 2011-04-12 14:26:53 EDT 
I verified this fix in the 3.7 stream. Released the same patch into the 4.1 stream builder.  Also,I released and tagged the e4.rcp feature so it would used shared licenses.
Comment 9 Kim Moir CLA 2011-04-18 13:37:20 EDT 
verified in 4.1 stream build I20110415-1030 as well.