Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341098 - Freeform Connection Bendpoints Don't Move As Expected
Summary: Freeform Connection Bendpoints Don't Move As Expected
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 0.8.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Indigo M7 Theme_bugs
Keywords:
: 341969 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-28 09:13 EDT by Rhett Hudson CLA
Modified: 2013-02-28 09:23 EST (History)
6 users (show)

See Also:
michael.wenz: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rhett Hudson CLA 2011-03-28 09:13:22 EDT
Build Identifier: 

Given a freeform connection, with bendpoints between two anchors, where the anchors are contained by two different top-level container shapes, there is no mechanism for moving the bendpoints as a group. When the two top level containers are selected and the connection between them is also selected, the user likely expects the bendpoints to move when the whole selection group is dragged. At the moment, the top-level ContainerShapes and the anchored endpoints of the connection move, but the bendpoints between the anchor points do not.


Reproducible: Always
Comment 1 Michael Wenz CLA 2011-04-06 04:55:33 EDT
*** Bug 341969 has been marked as a duplicate of this bug. ***
Comment 2 Michael Wenz CLA 2011-04-06 04:56:20 EDT
For completeness, here's the comment from the duplicate bug:
In my diagram, I add some bendpoints on a connection between node A and node B.
Now I select both nodes and drag them. After I release mouse, both nodes are
moved. But the bendpoints on the connection don't get moved. 

I took a look of the DefaultMoveShapeFeature. That class does take care of
moving bendpoints on connections originating and ending on the same node. But
it doesn't take of bendpoints on connections between different nodes.
Comment 3 Konstantin Komissarchik CLA 2011-04-06 11:55:53 EDT
Increasing the severity as this issue makes using bendpoints darn near unusable. The common scenario of tweak the diagram then move it to make room for an addition is very frustrating.
Comment 4 Christian Brand CLA 2011-05-06 05:19:19 EDT
FIXED - This should pretty work now.
Comment 5 Michael Wenz CLA 2012-04-13 03:31:11 EDT
Bookkeeping
Comment 6 Vitor Enio CLA 2013-02-28 08:10:35 EST
Hi,

I was trying to move my Bendpoint and realized that this bug still occurs.

I'm using the Graphiti 0.9.1 updated from:
http://download.eclipse.org/graphiti/updates/0.9.1

Searching at the new Graphiti git repository (http://git.eclipse.org/c/gmp/org.eclipse.gmp.graphiti.git/commit/?h=b0_9_x&id=23b79c365b90c7a4673aef3bff62bd6f9f6c523f) I could see that this bug has been fixed and commited. 

But looking at the source code of my downloaded plugin I could see the DefaultMoveShapeFeature code is still bugged (the moveBendpointsAutomatically() method even exists).

So I realize that it should be fixed at 0.8.0 version, according to this bug "Target milestone" information. So, I updated my graphiti plugin with the 0.8.0 version but the bug isn't fixed too. I saw the source of the downloaded 0.10.0 and it still hasn't any of these fixes.

In other words, it looks like the bug has been fixed but wheren't appropriately released.

I would like know where were those bugfixes released and where can I update my Eclipse with the FIXED plugin release.

URLs I've used:
0.8.0 -> http://archive.eclipse.org/graphiti/updates/0.8.0/
0.9.1 -> http://download.eclipse.org/graphiti/updates/0.9.1
0.10.x -> http://download.eclipse.org/graphiti/updates/nightly/

Thank's in advance.
Comment 7 Michael Wenz CLA 2013-02-28 08:39:48 EST
Are you sure you have that scenario?

I just double checked that the fix is included and became part of Graphiti 0.8, 0.9 and the current master branch.

Checking for the method name moveBendpointsAutomatically is misleading, since the name has been changed to moveAllBendpoints afterwards.

Also I validated in the current head version using the tutorial that a free form connection with bendpoints connecting 2 classes will be moved correctly (together with the bendpoint) as soon as the two connected classes are moved.

In case this does not work for you, please provide more information on your scenario.
Comment 8 Vitor Enio CLA 2013-02-28 09:23:57 EST
Sorry Herr Wenz,

We just looked at the method name. Our main problem is in our own scenario.

By now we have all bendpoints moving correctly.

Thank you very much and sorry for our mistake.