Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341079 - [sandbox] items in Builds view should be able to show low level properties in properties view
Summary: [sandbox] items in Builds view should be able to show low level properties in...
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 208275 210639 244687 245823 273589
Blocks:
  Show dependency tree
 
Reported: 2011-03-28 05:58 EDT by maarten meijer CLA
Modified: 2011-08-11 08:27 EDT (History)
0 users

See Also:


Attachments
Hudson Builds showing properties (48.59 KB, image/png)
2011-03-28 06:12 EDT, maarten meijer CLA
no flags Details
Patch to add these Builds IPropertySource implementations to sandbox.dev (21.70 KB, patch)
2011-03-28 06:19 EDT, maarten meijer CLA
no flags Details | Diff
mylyn/context/zip (8.83 KB, application/octet-stream)
2011-03-28 06:19 EDT, maarten meijer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description maarten meijer CLA 2011-03-28 05:58:47 EDT
When trying to make a connector to the Builds view, it is convenient to see most of the attributes in the properties view.
Just as developing a Tasks connector is made easier by displaying info from the items in the Task List and Task Repositories view.

I have created a contribution that consist of:
- a "Show in Properties View" Action that allows the selected item in Builds view to be shown in Properties View
- an adapter factory for all Builds Property Source
- an IPropetySource implementation for BuildElement, BuildPlan and BuildServer
- changes to plugin.xml
- refactoring out of some code in AbstractMylynPropertySource

Please assign to me to complete.
Comment 1 maarten meijer CLA 2011-03-28 06:12:20 EDT
Created attachment 191989 [details]
Hudson Builds showing properties

Showing peperties in prpoerties views can be useful during developing and debugging Mylyn Builds connectors
Comment 2 maarten meijer CLA 2011-03-28 06:19:35 EDT
Created attachment 191990 [details]
Patch to add these Builds IPropertySource implementations to sandbox.dev

BuildElement
BuildPlan
BuildServer
Factory
AbstractMylynPropertySource
+ manifest/plugin.xml changes
Comment 3 maarten meijer CLA 2011-03-28 06:19:37 EDT
Created attachment 191991 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2011-03-28 22:58:59 EDT
The builds model is based on EMF. As far as I know EMF comes with integration for the properties view and it's probably just a matter of generating the corresponding classes? I would prefer that over maintaining a hand crafted solution.
Comment 5 maarten meijer CLA 2011-03-30 07:22:16 EDT
I understand your point.
I think EMF only generates PropertySources for Editors so maybe wit will not work. Time to read up on modelling with EMF then!
Comment 6 maarten meijer CLA 2011-04-29 14:45:39 EDT
I looked it up in the EMF book and property source generators work only in combination with Editors, not with other views.
Maybe we want to show more than the modeled object, for example also linked information.

I'm willing to take on maintenance of these, a well as the Task and Repository property sources, after all I created them. Please accept patch.
Comment 7 Steffen Pingel CLA 2011-08-11 08:27:04 EDT
(In reply to comment #6)
> I looked it up in the EMF book and property source generators work only in
> combination with Editors, not with other views.

If I look at the generated code ExtendedPropertySheetPage only seems to require an EditingDomain which should not depend on an actual editor implementation. I don't how difficult it would be to implement this for the Builds model but I would assume that you can create the necessary glue if you generate code the org.eclipse.mylyn.builds.edit plug-in. If there is use for it we could maintain that in the Builds project.
Comment 8 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn