Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341078 - Remove workaround for AspectJ bug
Summary: Remove workaround for AspectJ bug
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: runtime (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.7.0.M04   Edit
Assignee: daniel marthaler CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 292239
Blocks:
  Show dependency tree
 
Reported: 2011-03-28 05:45 EDT by Glyn Normington CLA
Modified: 2017-01-25 09:57 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2011-03-28 05:45:45 EDT 
The ExceptionCleaner aspect in util currently checks for Throwable:

after(Object o) throwing(Throwable t) : exposedViaJmx(o) {
      if (t instanceof Exception) {
          ....
      }
}

Once bug 292239 is fixed in AspectJ, this can be changed to"throwing(Exception)" and the instanceof check can be deleted.
Comment 1 Glyn Normington CLA 2011-03-28 05:46:27 EDT 
Need to upgrade AspectJ to pick up this fix.
Comment 2 Chris Frost CLA 2012-09-17 11:57:20 EDT 
We are now on AspectJ 1.6.12 and the Bug mentioned below has been fixed.
Comment 3 Glyn Normington CLA 2012-09-18 05:10:12 EDT 
Thanks for spotting this. We are free to try the tidy up suggested in the description.
Comment 5 Florian Waibel CLA 2017-01-25 09:57:06 EST 
LGTM.
Thanks Dani for fixing this.