Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341027 - [build] changesets should provide right file icon
Summary: [build] changesets should provide right file icon
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 0.9   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 350333
Blocks:
  Show dependency tree
 
Reported: 2011-03-26 01:57 EDT by Benjamin Muskalla CLA
Modified: 2011-07-15 19:13 EDT (History)
1 user (show)

See Also:

Attachments
patch (2.81 KB, patch)
2011-03-26 02:01 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (890 bytes, application/octet-stream)
2011-03-26 02:01 EDT, Benjamin Muskalla CLA 		no flags Details
patch (3.06 KB, patch)
2011-03-26 03:16 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
patch (commons) (2.55 KB, patch)
2011-07-14 19:23 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (37.17 KB, application/octet-stream)
2011-07-14 19:23 EDT, Benjamin Muskalla CLA 		no flags Details
patch (builds) (1.67 KB, patch)
2011-07-14 19:24 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
patch (tasks) (2.73 KB, patch)
2011-07-14 19:25 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
patch (builds) (3.07 KB, patch)
2011-07-14 19:44 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (2.44 KB, application/octet-stream)
2011-07-15 19:13 EDT, Steffen Pingel CLA 		no flags Details
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-03-26 01:57:59 EDT 
The files in the changes section should show the corresponding icons for the file.
Comment 1 Benjamin Muskalla CLA 2011-03-26 02:01:16 EDT 
Created attachment 191950 [details]
patch

.
Comment 2 Benjamin Muskalla CLA 2011-03-26 02:01:18 EDT 
Created attachment 191951 [details]
mylyn/context/zip
Comment 3 Benjamin Muskalla CLA 2011-03-26 03:16:49 EDT 
Created attachment 191952 [details]
patch

First one was broken
Comment 4 Steffen Pingel CLA 2011-03-26 23:54:59 EDT 
Looks good. We have similar code in AttachmentTableLabelProvider. Would be nice to generalize this in the commons.
Comment 5 Benjamin Muskalla CLA 2011-07-14 19:23:09 EDT 
Created attachment 199720 [details]
patch (commons)

Steffen, here is a patch for commons.

Wondered about two things:
* While CommonImages feels the right class, it doesn't align to the rest of the class. Maybe move this to CommonUiUtil?

* Adapted the idea to have a common image for "image files" as we do in the AttachmentTableLabelProvider
Comment 6 Benjamin Muskalla CLA 2011-07-14 19:23:11 EDT 
Created attachment 199721 [details]
mylyn/context/zip
Comment 7 Benjamin Muskalla CLA 2011-07-14 19:24:35 EDT 
Created attachment 199722 [details]
patch (builds)

.
Comment 8 Benjamin Muskalla CLA 2011-07-14 19:25:27 EDT 
Created attachment 199723 [details]
patch (tasks)

.
Comment 9 Benjamin Muskalla CLA 2011-07-14 19:44:49 EDT 
Created attachment 199724 [details]
patch (builds)

Also use it in the artifacts section.
Comment 10 Steffen Pingel CLA 2011-07-15 19:13:03 EDT 
Thanks Benjamin. I have applied the changes based on the work for bug 350333.
Comment 11 Steffen Pingel CLA 2011-07-15 19:13:05 EDT 
Created attachment 199777 [details]
mylyn/context/zip