Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 341014 - marketplace switcher should have a label like "Marketplaces"
Summary: marketplace switcher should have a label like "Marketplaces"
Status: CLOSED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: 1.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.2   Edit
Assignee: Carsten Reckord CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-25 17:42 EDT by Benjamin Muskalla CLA
Modified: 2015-12-16 13:51 EST (History)
5 users (show)

See Also:
ian.skerrett: kepler+


Attachments
screenshot (101.20 KB, image/png)
2011-04-12 20:26 EDT, Benjamin Muskalla CLA
no flags Details
proposed patch (5.58 KB, patch)
2011-04-13 18:45 EDT, Benjamin Muskalla CLA
no flags Details | Diff
mylyn/context/zip (4.59 KB, application/octet-stream)
2011-04-13 18:45 EDT, Benjamin Muskalla CLA
no flags Details
mpc_left.png (97.12 KB, image/png)
2011-04-19 21:39 EDT, Benjamin Muskalla CLA
no flags Details
mpc_top.png (110.16 KB, image/png)
2011-04-19 21:39 EDT, Benjamin Muskalla CLA
no flags Details
Using a banner (213.37 KB, image/jpeg)
2013-02-25 14:41 EST, Carsten Reckord CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-03-25 17:42:34 EDT
Talked with Ian about this. Having a label to represent annotate the viewer seems too much as we currently already have that so many "rows" in the wizard. Our idea was show the description in a light color as background of the viewer, right aligned.
Comment 1 Benjamin Muskalla CLA 2011-04-12 20:26:58 EDT
Created attachment 193111 [details]
screenshot

Ian, I'm currently playing around with different approaches to tackle this problem. Would be good to get your input on this screenshot.
Comment 2 Ian Skerrett CLA 2011-04-13 16:57:19 EDT
(In reply to comment #1)
> Created attachment 193111 [details]
> screenshot
> 
> Ian, I'm currently playing around with different approaches to tackle this
> problem. Would be good to get your input on this screenshot.

+1 looks good.   Lets see it in action.
Comment 3 Benjamin Muskalla CLA 2011-04-13 18:45:05 EDT
Created attachment 193206 [details]
proposed patch

I'm not happy yet with this solution. While it looks good with 3 marketplaces, you can barely see the watermark when there are more marketplaces.
Comment 4 Benjamin Muskalla CLA 2011-04-13 18:45:07 EDT
Created attachment 193207 [details]
mylyn/context/zip
Comment 5 Benjamin Muskalla CLA 2011-04-19 21:39:34 EDT
Created attachment 193635 [details]
mpc_left.png

Label on the left
Comment 6 Benjamin Muskalla CLA 2011-04-19 21:39:34 EDT
Created attachment 193636 [details]
mpc_top.png

Label on the top
Comment 7 Benjamin Muskalla CLA 2011-04-19 21:40:57 EDT
David, Ian, my personal favorite is to use the label on top of the marketplace switcher as this does not clash in the situation that we get more catalogs listed and is more consistent with the rest of the Eclipse UI. Any thoughts?
Comment 8 David Green CLA 2011-04-25 20:06:12 EDT
I like overlay, because it looks modern as is compact.  On the down side, I'm sure that it violates UI design guidelines, could hard to make accessible, and has the shortcoming of breaking down with more marketplaces.  Ian can provide guidelines as to how many marketplaces we could expect.  On top is the safer option.
Comment 9 Benjamin Muskalla CLA 2011-05-19 10:03:30 EDT
Ian, any input on this to get this into RC2? I agree with David that we may should this on top of the marketplace switcher (see comment 6) or leave it out completely.
Comment 10 Martin Oberhuber CLA 2012-10-08 18:17:17 EDT
As an end user, I find the concept of having to choose a marketplace before I can search fairly odd. Let's say I'm searching a hex editor plugin. How would I know whether I find that on the "Eclipse" marketplace, or on Yocto, or on Obeo ?

I'd think that when a Search is initiated, it should search all registered marketplaces in parallel. Then the marketplace selector becomes really a filter which I can apply if I want, making it far less relevant than today since by default all market places would be searched.

I acknowledge that merging the search results may be non-trivial ... but well, that's what I'd intuitively expect as an end user.
Comment 11 Ian Skerrett CLA 2012-11-23 13:53:33 EST
(In reply to comment #10)
> As an end user, I find the concept of having to choose a marketplace before
> I can search fairly odd. Let's say I'm searching a hex editor plugin. How
> would I know whether I find that on the "Eclipse" marketplace, or on Yocto,
> or on Obeo ?
> 
> I'd think that when a Search is initiated, it should search all registered
> marketplaces in parallel. Then the marketplace selector becomes really a
> filter which I can apply if I want, making it far less relevant than today
> since by default all market places would be searched.
> 
> I acknowledge that merging the search results may be non-trivial ... but
> well, that's what I'd intuitively expect as an end user.

I agree that it would be ideal from an end-user perspective but I think the implementation would be a huge challenge.
Comment 12 Carsten Reckord CLA 2013-02-06 11:35:07 EST
I talked with Ian about this a bit more. To avoid overlap between the label and the marketplace, we'd currently favor a solution with the label on top. The idea is to use a banner like the "Featured" one in the result list to make it look nice and consistent. We're currently trying to figure out how to do that without too much vertical space creep (the first sugestion was to reduce the "empty" space below the marketplaces. But that's of course used by the progress bar during server communication...).

I'll post a mockup shortly.
Comment 13 Carsten Reckord CLA 2013-02-06 13:15:05 EST
(In reply to comment #10)
I also like the idea of a unified search. But to keep things focused and because that would be a pretty big change, I'd suggest splitting that off into a separate ticket. I've created bug 400135.
Comment 14 Carsten Reckord CLA 2013-02-25 14:41:34 EST
Created attachment 227561 [details]
Using a banner

Here's a mockup using a banner for the Marketplaces label. There are quite a few more changes in the screenshot, but for now, let's maybe focus on the marketplaces area.
Comment 15 Carsten Reckord CLA 2013-03-15 11:29:50 EDT
I've pushed a fix in commit c46dcb04aa35cbd18167658e4429cafd799828de. The switcher now displays its title using the same kind of banner as the solutions list. 

While I was at it, I've removed the superfluous separator from the banner and fixed the position of the label to be correctly centered vertically.
Comment 16 Carsten Reckord CLA 2015-12-16 13:51:41 EST
Cleanup: closing all released fixes.