Community
Participate
Working Groups
Build Identifier: Eclipse SDK 3.6.2 The update site URL was not added when calling org.eclipse.equinox.p2.director to install a feature which uses addRepository touchpoint action to add an repository site URL. Reproducible: Always Steps to Reproduce: 1. Create a feature project and add a p2.inf to it 2. Call the addRepository touchpoint action to add a URL like the following instructions.configure=org.eclipse.equinox.p2.touchpoint.eclipse.addRepository(type:0,location:http${#58}//tpftoolkit/temp/test_update,name:Test site);\ org.eclipse.equinox.p2.touchpoint.eclipse.addRepository(type:1,location:http${#58}//tpftoolkit/temp/test_update/,name:Test site); 3. Create an update site project, add the feature and build it 4. Upload the repository to the web server on tpftoolkit/temp/test_update/ It's important to put it at the same spot as the repository url defined in the p2.inf file 5. Run the following command to install the feature eclipse.exe -application org.eclipse.equinox.p2.director -repository http://tpftoolkit/temp/test_update1/ -installIU com.ent.feature.group 6. The feature is installed but the URL is not added to the repository list 7. If the repository is moved to another spot, one whose url is different from the one defined in the p2.inf file, the URL will be added when the feature is installed.
This is what is happening: - the repository isn't in the list to begin with - the director application adds it and marks it for removal - we install the feature - we add the repository to the list (already there) - the director application removes the repository There is a count object but I'll have to investigate further to see how we use that.
Ah, this is the code that prevents the director application from polluting the install with repos required by that director invocation. But in this case since the touchpoint is adding it, the director should not remove it.
Created attachment 200394 [details] patch (work in progress)
Released to master branch. http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=c5849e4e4b34eb67b11eba909ef2f61c71d30538
Thank you, DJ, for fixing the problem. Wonder whether I can pick up the new driver. I found a 3.8 driver built on 07/27 but the status for windows was marked with a red cross. http://download.eclipse.org/eclipse/downloads/drops/I20110727-2000/index.php
I download the driver and it works fine. Thank you, DJ.
Hi DJ, We are still on Eclipse 3.6. Wonder whether this fix can be ported back to 3.6. Thanks.
