Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340947 - Fetch patchset from task editor into Git repository
Summary: Fetch patchset from task editor into Git repository
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.8   Edit
Assignee: Sascha Scholz CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2011-03-25 08:17 EDT by Sascha Scholz CLA
Modified: 2011-05-15 16:45 EDT (History)
1 user (show)

See Also:

Attachments
screenshot (7.80 KB, image/png)
2011-05-15 16:45 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Scholz CLA 2011-03-25 08:17:44 EDT 
Provide a button in task editor that opens EGit's "Fetch from Gerrit" dialog with a refspec for a specific patchset. Depends on http://egit.eclipse.org/r/#change,2781.
Comment 1 Sascha Scholz CLA 2011-03-25 08:46:54 EDT 
http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/log/?h=sscholz/fetch-from-task-editor

It would be very nice if someone could review my commit. Thx.
Comment 2 Sascha Scholz CLA 2011-03-25 13:27:31 EDT 
For the above change I haven't managed to get the target definition working (tried only with 3.6). First I had to reorder the repository entries to get the Mylyn 3.5.0 at all (otherwise the target editor only resolved 3.4.0). Then I tried to add <unit id="org.eclipse.mylyn.test_feature.feature.group" version="0.0.0"/> to pull in org.eclipse.mylyn.tests.util which is required by org.eclipse.mylyn.gerrit.tests. Worked, but this required org.eclipse.swtbot.eclipse.core 2.0.0 which couldn't be resolved. I have no idea where to get it from or how to search for it. Does anybody have hints how to resolve the mess?
Comment 3 Steffen Pingel CLA 2011-03-26 23:52:27 EDT 
I don't know what you are referring to when you say "mess". I have removed the explicit target definitions as this was causing too much maintenance overhead. Note that I plan to abstract that further (bug 339956). Can you try again? 

In case you are using PDE I recommend the target definitions in org.eclipse.mylyn.releng/target-definitions.

Anyways, I think this feature addition is great!
Comment 4 Sascha Scholz CLA 2011-03-27 09:57:48 EDT 
By talking about "mess" I wanted to express my feelings about my missing understanding about target definitions... ;-)

I'm going to try out the changed configuration soon. However, I don't know if it's a good idea to have separate target platforms for PDE and Tycho. I've always liked the idea of a common definition that I could work with in PDE. Regarding org.eclipse.mylyn.releng/target-definitions you have to take into account that not all of us have committer rights there to share configuration changes.

Anyways, thanks for your kudos! ;-)
Comment 6 Steffen Pingel CLA 2011-05-15 16:45:46 EDT 
Created attachment 195679 [details]
screenshot