Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340899 - Metatype service implementation ignores Bundle-Localization manifest header.
Summary: Metatype service implementation ignores Bundle-Localization manifest header.
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: John Ross CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340874
  Show dependency tree
 
Reported: 2011-03-24 15:16 EDT by John Ross CLA
Modified: 2011-03-25 10:14 EDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (18.93 KB, patch)
2011-03-24 16:41 EDT, John Ross CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Ross CLA 2011-03-24 15:16:39 EDT 
Build Identifier: 

The Metatype service is required to follow the same localization mechanism described in the core spec unless overriden by the 'localization' attribute of the <MetaData> element. The default base name for property files is "OSGI-INF/l10n/bundle'; however, the core spec allows this to be overridden with the Bundle-Localization manifest header. The current implementation always uses the default base name and does not inspect the header.

Reproducible: Always
Comment 1 John Ross CLA 2011-03-24 16:41:15 EDT 
Created attachment 191865 [details]
Proposed Patch

This patch updates the Metatype implementation so that the Bundle-Localization manifest header, when specified, will override the default base name. It also adds a new test to compendium.tests.
Comment 2 Thomas Watson CLA 2011-03-25 10:06:04 EDT 
I released a modified patch:

- I created a static method for getting the bundle localization base
- I change the call to Bundle.getHeaders() to Bundle.getHeaders("") because we want the raw value of the Bundle-Localization header.
- I updated the AllTests class to include the new test suite.