Community
Participate
Working Groups
Build Identifier: When displayed in a console that supports the Metatype service specification, such as the Apache Web Console, the metadata shows 'null' for all attribute names and descriptions. Also, the OCD name and description are displayed as the localization key, not the localized value. Reproducible: Always
Created attachment 191836 [details] Proposed Patch The localization properties (configurationName and configurationDescription) that existed were placed in plugin.properties, but the "localization" attribute on the <MetaData> element was not specified. By default, properties are searched for in OSGI-INF/l10n/bundle*.properties, which didn't exist. One option was to continue to use plugin.properties and add the "localization" attribute with the appropriate value. Instead, I chose to follow the more standard option of using OSGI-INF/l10n. The two localization properties within plugin.properties were moved to OSGI-INF/l10n/bundle.properties. No names or descriptions were specified on any of the attribute definitions. These were added and localized. New defaults were added where possible in order to avoid cardinality=1 and processing attributes as Object[]. A few attributes did not have reasonable defaults. For these, the code was updated to process them as Object[]. Made <Designate> ocdref and <OCD> id the same as <Designate> pid and factorypid as a workaround to a known Apache Web console issue (see https://issues.apache.org/jira/browse/FELIX-1865?focusedCommentId=13010698&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13010698). This was possible because multiple designates do not need to reference the same ocd. If that becomes necessary, the web console issue is unavoidable.
Simon, cc'ing you because it might be worthwhile for you to review, particularly the added defaults. Brian, cc'ing you as the original reporter of this issue.
Thanks John, I took a quick glance and am a bit concerned about the change from String to String[] and if that will affect existing usage. Talking and traveling today, but will take a deeper look Monday.
Simon, don't spend too much time looking at this. John needs to attach another patch because there is actually a bug in the equinox metatype impl that was causing it to not use the NLS values from the plugin.properties file. I am also concerned about the String[] vs String changes. It seems the metadata is incorrectly allowing multiple values for the cardinality in these cases. The Cardinality likely should be 1 for everything in the metadata.
Created attachment 191875 [details] Alternate Patch This alternate patch changes the cardinality to zero for the remaining three attribute definitions whose cardinality was one. This ensures none of the values will be delivered as scalars, not arrays or vectors. There are no necessary code changes with this approach. Also, this patch puts all the localization properties into the plugin.properties file, which is referenced in the Bundle-Localization manifest header. Note this patch depends on the one attached to Bug 340899.
I released this patch. I also updated the bundle version of jetty6. I am surprised the version has not increased since the 3.4 release. I know we have released bug fixes to this bundle since then.
(In reply to comment #6) > ... I am > surprised the version has not increased since the 3.4 release. I know we have > released bug fixes to this bundle since then. Me too. I wonder if what we're seeing is a bit artificial because this bundle went live in 3.5 and so perhaps was not an entirely good citizen in terms of manifest version numbering.
See bug310466 and the fallout in bug341031 as a result of me updating this version. Well it is fixed now. ;-)
