Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340834 - Symlink tests fail on Win7 due to Bug 363463
Summary: Symlink tests fail on Win7 due to Bug 363463
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M7   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 331716 341334 363463
Blocks:
  Show dependency tree
 
Reported: 2011-03-24 04:43 EDT by Szymon Brandys CLA
Modified: 2012-04-02 10:53 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-03-24 04:43:04 EDT 
testBug232426(org.eclipse.core.tests.internal.localstore.SymlinkResourceTest) still fails on Win7. No matter it is run as an administrator or a regular user.
Comment 1 Szymon Ptaszkiewicz CLA 2011-06-07 13:05:25 EDT 
I have compared the execution of the test on Win7 and on Linux and it turned out that the test fails on Win7 because java.io.File#getCanonicalPath() does not resolve symbolic links on Win7. See http://download.oracle.com/javase/6/docs/api/java/io/File.html#getCanonicalPath(). This is why  UnifiedTree#isRecursiveLink() keeps returning "false" on Win7 while at the same time on Linux it returns "true" (the loop is correctly discovered).
Comment 2 Szymon Brandys CLA 2011-11-10 07:42:32 EST 
I wonder if it is a problem in their javadoc or they do not support Win7 symlinks on purpose. Szymon, could you check if there is a bug for Java to support Win7 symlinks?
Comment 3 Szymon Brandys CLA 2011-11-10 07:53:15 EST 
And the test should be disabled on Win7, not only for Hudson on Win7.
Comment 4 Szymon Brandys CLA 2011-11-10 08:05:11 EST 
And I guess that the same problem is with #testBug358830?
Comment 5 Szymon Ptaszkiewicz CLA 2011-11-10 08:11:11 EST 
I think the same problem is with all tests that are using #isHudsonOnWin7.
Comment 6 Szymon Brandys CLA 2011-11-10 08:59:16 EST 
I raised Bug 363463 describing the issue with UnifiedTree#isRecursiveLink() and changed the summary of Bug 340834. Szymon P., I think that tests should use isWin7 checks instead of isHudsonOnWin7. Please make this change and close the bug. Bug 363463 would be used for investigating the problem with UnifiedTree#isRecursiveLink().
Comment 7 Szymon Brandys CLA 2012-04-02 10:44:06 EDT 
Fixed with f8b1945446be74ddfe0e56946568f23b3cb331d5.