Description tundra 2011-03-23 21:41:45 EDT

Build Identifier: Version: 3.6.1 

Publish helper's approach to  moving files during publishing does not work when publishing to a path on a different device. The publish moves file from .metadata/.plugins/org.eclipse.jst.server.generic.core/tmp directory to a directory supplied in AbstractModuleAssembler.Factory .getModuleAssembler(module, getServer(), p);

The offending code is in PublishHelper.moveTempFile(File tempFile, File file) method.

 /**
   * Utility method to move a temp file into position by deleting the original and
   * swapping in a new copy.
   *
   * @param tempFile
   * @param file
   * @throws CoreException
   */
  private void moveTempFile(File tempFile, File file) throws CoreException
  {
    if (file.exists()) {
      if (!safeDelete(file, 2)) {
        // attempt to rewrite an existing file with the tempFile contents if
        // the existing file can't be deleted to permit the move
        try {
          InputStream in = new FileInputStream(tempFile);
          IStatus status = copyFile(in, file.getPath());
          if (!status.isOK()) {
            MultiStatus status2 = new MultiStatus(ServerPlugin.PLUGIN_ID,
                                                  0,
                                                  NLS.bind(Messages.errorDeleting,
                                                           file.toString()),
                                                  null);
            status2.add(status);
            throw new CoreException(status2);
          }
          return;
        } catch (FileNotFoundException e) {
          // shouldn't occur
        } finally {
          tempFile.delete();
        }
        /*if (!safeDelete(file, 8)) {
                                         tempFile.delete();
                                         throw new CoreException(new Status(IStatus.ERROR, ServerPlugin.PLUGIN_ID, 0, NLS.bind(Messages.errorDeleting, file.toString()), null));
                                 }*/
      }
    }
    if (!safeRename(tempFile, file, 10))
      throw new CoreException(new Status(IStatus.ERROR,
                                         ServerPlugin.PLUGIN_ID,
                                         0,
                                         NLS.bind(Messages.errorRename,
                                                  tempFile.toString()),
                                         null));
  }

Reproducible: Always

Steps to Reproduce:
1. Create a custom Publisher
2. In that publisher create an AbstractModuleAssembler using AbstractModuleAssembler.Factory          .getModuleAssembler(IModule module, GenericServer server, IPath path);
3. publish a webapp via Eclipse.