This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 340824 - CycleValidator Logic is wrong
Summary: CycleValidator Logic is wrong
Status: RESOLVED FIXED
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 20:46 EDT by Richard Craddock CLA
Modified: 2011-03-24 18:46 EDT (History)
1 user (show)

See Also:

Attachments
patch (1.17 KB, text/plain)
2011-03-24 18:10 EDT, Valentin Yerastov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Craddock CLA 2011-03-23 20:46:44 EDT 
In the CycleValidator, the logic is detecting DUPLICATE entries in the dependency graph as errors even when tehy are not cyclical.

eg

A depends on B and C

B depends on C

Will result in an incorrect error marker, because it discovers C twice.

I have disabled the check...
Comment 1 Valentin Yerastov CLA 2011-03-24 18:10:22 EDT 
Created attachment 191876 [details]
patch

The issue is fixed.
Comment 2 Yuri Strot CLA 2011-03-24 18:46:49 EDT 
Valentin's patch applied.