Community
Participate
Working Groups
Now that bug 323887 has been fixed, the releng build scripts should be modified so the Eclipse SDK feature is marked as "locked" and cannot be uninstalled.
Will upgrade basebuilder with next I-build's bundles so I can release this change.
DJ, I changed the way the director is called so the extraArgs include the iuProfileProperties path now <ant antfile="${eclipse.pdebuild.scripts}/genericTargets.xml" target="runDirector" inheritAll="true"> <property name="p2.repo" value="file:${p2.repo}" /> <property name="p2.director.iu" value="${p2.director.installIU}" /> <property name="p2.director.installPath" value="${p2.director.install.path}" /> <property name="os" value="${p2.os}" /> <property name="ws" value="${p2.ws}" /> <property name="arch" value="${p2.arch}" /> <property name="p2.director.log" value="${directorlog}" /> <property name="equinoxLauncherJar" value="${base.builder}/plugins/org.eclipse.equinox.launcher.jar" /> <property name="vmargs" value="-Dorg.eclipse.ecf.provider.filetransfer.retrieve.closeTimeout=3000 -Dorg.eclipse.ecf.provider.filetransfer.retrieve.readTimeout=3000"/> <property name="p2.director.extraArgs" value="-profileProperties org.eclipse.update.install.features=true -iuProfileProperties ${equinox.build.configs}/equinox.prov/lock.properties" /> </ant> ${equinox.build.configs}/equinox.prov/lock.properties looks like this org.eclipse.sdk.feature.group.key.0=org.eclipse.equinox.p2.type.lock org.eclipse.sdk.feature.group.value.0=1 However, I can still uninstall the SDK. Any ideas?
Can you attach the latest profile that is the result of the install? Thanks.
Created attachment 192962 [details] last profile
Created attachment 192963 [details] previous profile
Was this a valid build? Were there any error logs? The "last" profile is empty.
Yes, it was a valid build. The issue is that I shouldn't be able uninstall the SDK, but I can. "Last profile" refers to the profile where I removed the SDK. The "previous profile" refers to the initial profile from the build.
DJ, Can you send me a profile where this property is defined?
The property needs to be set on the org.eclipse.sdk.ide IU like this: org.eclipse.sdk.ide.key.0=org.eclipse.equinox.p2.type.lock org.eclipse.sdk.ide.value.0=1 I'm debugging it now but I think there is a problem when there are multiple IUs with the same ID but different version. For instance, I can reproduce this by trying to install the SDK from the i-builds repo. I do a query to see if "org.eclipse.sdk.ide" is a valid IU and it is, but I think the director is trying to set the property on a different version than will be installed, so that's why it fails. If you are installing from a repository with only a single version, it should work.
Okay thanks DJ, I'll restart the director install with the new property and try installing from a single-child repo.
Created attachment 193081 [details] patch
It works when there is a single child repo in the composite repo. Also, there was a typo in my build scripts yesterday. I'll close this for now and then update to the newer bundles next week to address bug 342492.
