Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340738 - [Table] Utility method to create a coherent tableInstance
Summary: [Table] Utility method to create a coherent tableInstance
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 06:48 EDT by Gregoire Dupe CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: juno+

Attachments
Patch for Bug 340738 (10.61 KB, patch)
2011-03-23 07:24 EDT, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2011-03-23 06:48:33 EDT 
Hello,

We need a utility method to create a coherent tableInstance which will be passed to the method org.eclipse.emf.facet.widgets.nattable.INatTableWidgetFactory.createNatTableWidget(Composite, IEditingDomainProvider, TableInstance, MenuManager).

This utility method will be called by the components which need to instantiate the table method.

Regards
Gregoire Dupe
Comment 1 Nicolas Guyomar CLA 2011-03-23 07:24:24 EDT 
Created attachment 191739 [details]
Patch for Bug 340738

Hi,

Please find attached the corresponding modifications.
I've added NatTableWidgetUtils.java which contains the createTableInstance(...) method.

NatTableEditorFactory and NatTableView now uses this method

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-03-23 08:32:51 EDT 
Comment on attachment 191739 [details]
Patch for Bug 340738


Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 446.
Comment 3 Nicolas Guyomar CLA 2011-03-23 08:37:59 EDT 
Hi,

Before closing this bug we need to extract the column instantiation from the NatTableWidget class to this new utility class.

Nicolas
Comment 4 Gregoire Dupe CLA 2012-05-23 12:26:04 EDT 
This bug has to be closed for the IP log.