Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340687 - edc - TraceView - dead code & unfinished cleanup when exporting trace log
Summary: edc - TraceView - dead code & unfinished cleanup when exporting trace log
Status: RESOLVED WONTFIX
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0.1   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 13:09 EDT by Kirk Beitz CLA
Modified: 2019-12-30 18:39 EST (History)
1 user (show)

See Also:


Attachments
refactor to eliminate dead code; additional catch blocks to properly close all (2.09 KB, patch)
2011-03-22 13:09 EDT, Kirk Beitz CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2011-03-22 13:09:30 EDT
Created attachment 191701 [details]
refactor to eliminate dead code; additional catch blocks to properly close all

in EDCTraceView.java , code analysis reveals a couple of sections of dead code w.r.t. the Reader and Writer in handleExport.

this also exposes that the Reader in and Writer out may never properly have .close() called on them, and also that if in.close() throws IOException, out.close() will never be called.

the same is true of the result in private copy() … if the reader.close() throws IOException, writer.close() will never be processed.
Comment 1 Jonah Graham CLA 2019-12-30 18:39:37 EST
(this is part of a batch change)

The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix.

The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/