Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340570 - [rulers][api] Pull up #addVerticalRulerColumn and #removeVerticalRulerColumn from ProjectionViewer to SourceViewer
Summary: [rulers][api] Pull up #addVerticalRulerColumn and #removeVerticalRulerColumn ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard: 3.8 candidate
Keywords: api
Depends on:
Blocks: 272267
  Show dependency tree
 
Reported: 2011-03-21 10:33 EDT by Tomasz Zarna CLA
Modified: 2011-10-26 04:20 EDT (History)
3 users (show)

See Also:


Attachments
Fix v01 (4.75 KB, patch)
2011-09-14 06:11 EDT, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (6.13 KB, application/octet-stream)
2011-09-14 06:11 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-03-21 10:33:49 EDT
Pulling up #addVerticalRulerColumn and #removeVerticalRulerColumn from ProjectionViewer to SourceViewer would be the neatest way of fixing bug 272267. This enhancement request is about making this happen or at least finding a better approach.
Comment 1 Tomasz Zarna CLA 2011-09-14 06:11:39 EDT
Created attachment 203326 [details]
Fix v01
Comment 2 Tomasz Zarna CLA 2011-09-14 06:11:42 EDT
Created attachment 203327 [details]
mylyn/context/zip
Comment 3 Szymon Brandys CLA 2011-10-06 07:14:38 EDT
Ping. Since it is an API change, can we do it early?
Comment 4 Dani Megert CLA 2011-10-12 09:23:09 EDT
(In reply to comment #3)
> Ping. Since it is an API change, can we do it early?

Sure. Fixed in master: 426b769e7fe9341d7b1cc78660223f861ffaf493
Comment 5 Dani Megert CLA 2011-10-26 04:20:42 EDT
Verified through code inspection.