Community
Participate
Working Groups
Created attachment 191612 [details] Eclipse Gemini DBAccess Refactoring (around christmas 2010) Hi all, please find attached my refactoring and extension of Eclipse Gemini DBAccess. Any feedback is welcome :-). So let's see how we can add this stuff to Gemini DBAccess. Regards David
Hi David, thank you for your contribution. I will have a look at it as soon as possible. - Jürgen
Hi David, sorry for the late reply --- due to private reasons I wasn't able to test your contribution earlier. I have downloaded your attachment and tried to make it run: -- It is obviously a pretty sophisticated piece of work, and I fully agree, it is certainly worthwhile to head towards an automated build. -- It took me a while to get the maven/tycho build running, because your project still requires a considerable amount of manual work. some of the maven artifacts have to be created manually, absolute paths in the poms didn't match my setup, maven has to executed three times in different directories in the correct order. -- After the successful maven build, I tried to import the complete set of projects into eclipse, but the projects didn't resolve successfully – presumably there are further configuration steps involved. Until now, I didn't spend too much time on that. -- As far as I can see, you have made the decision to have a separate bundle for the common part of the DBAccess services (org.eclipse.gemini.dbaccess.common). Mike tried to avoid this this additional bundle to prevent an inflation of bundles. I have been experimented to find a solution with maven and tycho, where the common part is directly included into the DBAccess bundle for each driver (meaning a replication of code). Unfortunately I wasn't able to find a nice and clean method to combine eclipse and maven/tycho --- as far as I can tell such a solution might be impossible. Is that your observation too? -- So far, I haven't checked the licenses. Your attachment is far more that an increment of the existing source, which makes it harder to include it a a contribution. Furthermore we need a general discussion about how to proceed with the project (independent of your enhancement suggestion). So please stay tuned and please participate in this discussion. Have you subscribed to the mailing list(http://www.eclipse.org/gemini/dbaccess/contribute/)? -Juergen
Hi David, sorry for the late reply. In the meanwhile we had a thorough discussion within the Gemini umbrella project about the best way of integrating your contributions. The goal is to comply with the legal requirements of the Eclipse Foundation and at the same time to minimize the administrative overhead such that the changes can be incorporated as soon as possible. This is what we came up with: First of all, I want to emphasize that the approach of you contribution is valid and there is nothing wrong about it. However, as already stated in my last comment, your attachment is far more that an increment of the existing source, which makes it harder to include --- to be honest, it is almost impossible with reasonable effort. We would still very much like to incorporate the support of further database platforms. I would like to ask you to look at how this is done for MySQL. The best and easiest way is to minimize the amount of contributed code to the necessary minimum. That is, we would like our contributors to submit the support for a new database platform such that it does not contain any boilerplate stuff such as licenses, auto-generated Eclipse project meta data,... With that we stay well below the 250 lines barrier, beyond which a much higher administrative effort would be required. Right now, Gernot is also preparing a contributon which might serve as an example (please refer to https://bugs.eclipse.org/bugs/show_bug.cgi?id=365469). I think this strategy helps you as contributors and us as committers. What do you think? Best Regards, Jürgen
David, I am closing this bug, because there was no activity on it for the last year. We are still very much interested in contributions. Thanks a lot for your effort! With Git/Gerrit now in place, it should be easier to contribute. So please give it a try! Best Regards, Juergen Ps.: Interestingly, on of the problems of David's approach seems to be addressed by https://bugs.eclipse.org/bugs/show_bug.cgi?id=393053.
