Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340565 - [Compatibility] Missing "none" grouping in Problems view
Summary: [Compatibility] Missing "none" grouping in Problems view
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 RC2   Edit
Assignee: Remy Suen CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
: 332306 344865 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-21 09:46 EDT by DJ Houghton CLA
Modified: 2011-06-21 14:07 EDT (History)
2 users (show)

See Also:


Attachments
CompoundContributionItem patch v1 (2.52 KB, patch)
2011-05-16 13:36 EDT, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2011-03-21 09:46:05 EDT
Version: 4.1.0
Build id: I20110316-1035

In my Problems view I configure the contents to show only markers with Error severity. Then I like to turn off Grouping because there is no need to have all the error collapsed in the view. But there is no way to turn off the grouping in the e4 Problems view.
Comment 1 Remy Suen CLA 2011-03-21 11:59:43 EDT
This is the problem where the 'Group By' submenu only shows 'Java Problem Type', correct? Or I guess really all of the submenus of that view's menu seems to only show one item.
Comment 2 DJ Houghton CLA 2011-03-21 12:02:33 EDT
Yep. Hmm.. although I am in a new workspace and now the only entry in the list is Plug-in Problem Type. I just need the "None" entry. :-)
Comment 3 Remy Suen CLA 2011-05-05 13:21:06 EDT
*** Bug 344865 has been marked as a duplicate of this bug. ***
Comment 4 Remy Suen CLA 2011-05-16 11:43:14 EDT
java.lang.Exception
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:752)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at sun.reflect.GeneratedMethodAccessor20.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
	at java.lang.reflect.Method.invoke(Method.java:600)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.showMenu(MenuManagerRendererFilter.java:229)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.handleShow(MenuManagerRendererFilter.java:201)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.safeHandleEvent(MenuManagerRendererFilter.java:183)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.access$1(MenuManagerRendererFilter.java:140)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter$SafeWrapper.run(MenuManagerRendererFilter.java:127)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.handleEvent(MenuManagerRendererFilter.java:137)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1262)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1058)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:4864)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4540)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:341)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1610)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2059)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4970)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:256)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4204)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3746)
	at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer.showMenu(LazyStackRenderer.java:461)
	at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer$3.widgetSelected(LazyStackRenderer.java:413)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)

java.lang.Exception
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:752)
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:678)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.showMenu(MenuManagerRendererFilter.java:253)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.handleShow(MenuManagerRendererFilter.java:201)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.safeHandleEvent(MenuManagerRendererFilter.java:183)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.access$1(MenuManagerRendererFilter.java:140)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter$SafeWrapper.run(MenuManagerRendererFilter.java:127)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererFilter.handleEvent(MenuManagerRendererFilter.java:137)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1262)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1058)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:4864)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4540)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:341)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1610)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2059)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4970)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:256)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4204)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3746)
	at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer.showMenu(LazyStackRenderer.java:461)
	at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer$3.widgetSelected(LazyStackRenderer.java:413)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
Comment 5 Remy Suen CLA 2011-05-16 13:36:22 EDT
Created attachment 195768 [details]
CompoundContributionItem patch v1

As the contribution item believes that it is not dirty, the menu manager doesn't do anything about the items it generates and ultimately ends up disposing it. If we have the item always declare itself as being dirty then its items will always get regenerated.
Comment 6 Remy Suen CLA 2011-05-16 13:51:07 EDT
(In reply to comment #5)
> Created attachment 195768 [details]
> CompoundContributionItem patch v1

Patch released to CVS HEAD.
Comment 7 Remy Suen CLA 2011-05-24 09:24:30 EDT
Verified that the 'Show', 'Group By', and 'Sort By' submenus now work properly with I20110523-2200 on Windows XP.
Comment 8 Remy Suen CLA 2011-06-21 14:07:09 EDT
*** Bug 332306 has been marked as a duplicate of this bug. ***