Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340478 - Variables/Registers/Expressions view refresh button enable/disable state gets messed up if the view is pinned
Summary: Variables/Registers/Expressions view refresh button enable/disable state gets...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Project Inbox CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 16:59 EDT by Winnie Lai CLA
Modified: 2011-04-01 10:23 EDT (History)
2 users (show)

See Also:

Attachments
fix enablement state (2.54 KB, patch)
2011-03-18 17:24 EDT, Winnie Lai CLA 		pchuong: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Winnie Lai CLA 2011-03-18 16:59:44 EDT 
Build Identifier: 3.7  I20110127-2034

When pin variables view to dsf debugger, then selects launch view to use cdi debugger, the refresh button of variables view gets disabled. It should be enabled at this point because the variables view has been pinned to dsf debugger that allows refresh.
This problem happens as well to registers view and expresions view.

This problem happens as well to the latest HEAD at the time of bug submission.


Reproducible: Always

Steps to Reproduce:
1. Launch cdi debugger and dsf debugger.
2. Pin variables/registers/expression view to dsf debugger. At this point the refresh button is correctly enabled.
3. In Launch view, select cdi debugger.
At this time, the variables/registers/expression refresh button is disabled but should be enabled.
Comment 1 Winnie Lai CLA 2011-03-18 17:24:51 EDT 
Created attachment 191557 [details]
fix enablement state

Please review this small fix. I hope this fix can be included in the coming milestone Indigo M7.
Comment 2 Patrick Chuong CLA 2011-04-01 09:44:46 EDT 
The patch seems fine to me, committed the to HEAD.
Comment 3 CDT Genie CLA 2011-04-01 10:23:03 EDT 
*** cdt cvs genie on behalf of pchuong ***
Bug 340478 - Variables/Registers/Expressions view refresh button enable/disable state gets messed up if the view is pinned

[*] RefreshActionDelegate.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/actions/RefreshActionDelegate.java?root=Tools_Project&r1=1.2&r2=1.3