Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340461 - [client] Should the inline compare editor have syntax highlighting?
Summary: [client] Should the inline compare editor have syntax highlighting?
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 M2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 334213
  Show dependency tree
 
Reported: 2011-03-18 12:55 EDT by Mark Macdonald CLA
Modified: 2012-10-15 16:58 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-03-18 12:55:36 EDT 
1. Link a Git repository to a folder in your Orion workspace.
2. Commit a change to a .js file in the repository.
3. In the Orion navigator, select the .js file and use the "Git Log" action.
4. Click on the log message, and an editor will open showing the file contents.

The editor doesn't have any JS syntax highlighting.
Comment 1 Szymon Brandys CLA 2012-02-02 04:55:14 EST 
Libing is there any way to enable syntax assist in the inline editor?
Comment 2 libing wang CLA 2012-02-02 08:34:16 EST 
(In reply to comment #1)
> Libing is there any way to enable syntax assist in the inline editor?

The contents of the in-line viewer is mixed by original text and diff blocks.
I am not sure adding a syntax highlighter against such contents will introduce any funny result but we can try.
The text model used in inline viewer is kind of "sub class" from the general text model. Maybe we can play some tricks on that but I am afraid this will not be targeted for 0.4.
Comment 3 libing wang CLA 2012-10-04 17:23:43 EDT 
Already fixed.