340455 – [client] The compare Ui should stop crafting URIs inside

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 340455 - [client] The compare Ui should stop crafting URIs inside

Summary: [client] The compare Ui should stop crafting URIs inside

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Client (show other bugs)
Version:	0.2
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	0.2
Assignee:	libing wang
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	340449
Blocks:	334213
	Show dependency tree

Reported:	2011-03-18 12:06 EDT by Szymon Brandys
Modified:	2011-09-01 11:41 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Szymon Brandys

2011-03-18 12:06:33 EDT

Once bug 340449 is fixed, we need to fix the problem with crafted URIs in the Compare UI. I would like to use /compare.html to display differences between commits. The current shape of Compare UI does not work with Diff URIs like http://localhost:8080/git/diff/981adb594d627930c21444778dee6ebaca83bae1..de593852964351e629daad4e5e2814cfdcb1aaab/file/E/bundles/org.eclipse.orion.client.git/static/js/gitCommands.js

Comment 1 libing wang

2011-04-01 15:57:37 EDT

fixed at 5cbab9ee9afcde2ef1900ca88e813787f5c94bfa.
If you use  http://localhost:8080/git/diff/981adb594d627930c21444778dee6ebaca83bae1..de593852964351e629daad4e5e2814cfdcb1aaab/file/E/bundles/org.eclipse.orion.client.git/static/js/gitCommands.js , the left side will be editable .

If you use ?readonly=true at the end of the url , e.g.
http://localhost:8080/git/diff/981adb594d627930c21444778dee6ebaca83bae1..de593852964351e629daad4e5e2814cfdcb1aaab/file/E/bundles/org.eclipse.orion.client.git/static/js/gitCommands.js?readonly=true  ,the left side will be read only.

Comment 2 libing wang

2011-04-01 16:01:51 EDT

I recommend using compare-m.html as it will have all the diff actions and it is the M7 version editor.
The comapre.html uses gap model , which will be obsolete after M6.
So the full usage is "compare-m.html#yourDiffURI?readonly=true" for readonly left side , which is suitable for comparing 2 commits.