Community
Participate
Working Groups
Jeff was doing some p2 feature work earlier this week and noticed that our features are all over the place. (literally) They exist in different locations in the repository (some locations where the Equinox team members don't have write permission) as well as they are spread over multiple map files (which is complicated because if you change one thing, you might forget to check other related features because they are in other files). I talked to Kim and she agreed that we could move them without breaking everything. So let's do it.
Are you suggesting that the all equinox committers should have commit rights to all equinox features? I am also confused about what the intention is on moving the features. Right now we have features/ folders in CVS under each component and that folder is supposed to contain features that are related to the component. Are you suggesting we move these features in CVS to some single place for all equinox features?
Jeff and I chatted briefly the other day about the layout in CVS but it is unclear right now what the final result should/will be. As you mention, although some features have obvious destinations (like p2 ones), there are others which don't so should we create a general place for them? I think the initial problem is to update the map files and put all related features together.
(In reply to comment #2) > Jeff and I chatted briefly the other day about the layout in CVS but it is > unclear right now what the final result should/will be. As you mention, > although some features have obvious destinations (like p2 ones), there are > others which don't so should we create a general place for them? We could, but what that general place is will be hard to find since we have various components so picking one component as the general place probably will not make it much better. > > I think the initial problem is to update the map files and put all related > features together. I agree with this.
My intention was NOT to put all the equionx features in ONE spot but rather have them all in the Equinox repo. I like the bundle/features dir structure under the components etc. makes sense. There are a few features that transcend individual components. We already have some of those in the startkit and the equinox.core features. They are in the framework/features folder. I'm fine with that as the spot for "general" features. Most importantly IMHO is that there are equinox features in the various platform releng directories. These ones should move somewhere in the equinox repo. The map files are also a concern. some Equinox entires are in the core.map file. some in features.map, some in p2.map... Actually I'm fine with the last two. we can continue with the core.map and p2.map. The entries in features.map however should be moved. Likely to core.map. The overall goal here is to consolidate and make working in/with equinox easier and place more direct control with the team.
(In reply to comment #4) > My intention was NOT to put all the equionx features in ONE spot but rather > have them all in the Equinox repo. I like the bundle/features dir structure > under the components etc. makes sense. There are a few features that > transcend individual components. We already have some of those in the startkit > and the equinox.core features. They are in the framework/features folder. I'm > fine with that as the spot for "general" features. Agreed. > Most importantly IMHO is that there are equinox features in the various > platform releng directories. These ones should move somewhere in the equinox > repo. Agreed. I understand now the features DJ is referring to as "all over the place". > > The map files are also a concern. some Equinox entires are in the core.map > file. some in features.map, some in p2.map... Actually I'm fine with the last > two. we can continue with the core.map and p2.map. The entries in > features.map however should be moved. Likely to core.map. Fine with me. > > The overall goal here is to consolidate and make working in/with equinox easier > and place more direct control with the team. great. thanks for the clarification.
(In reply to comment #5) > > There are a few features that > > transcend individual components. We already have some of those in the startkit > > and the equinox.core features. They are in the framework/features folder. I'm > > fine with that as the spot for "general" features. The "general" features are in fact in the components/features folder NOT the framework/features folder in CVS. That seems like a fine place for high level features.
Created attachment 191783 [details] patch for map file changes Here is a patch for moving the features in the map files only. I will release the patch and then look at the locations in CVS.
It looks like the org.eclipse.equinox.sdk feature is the only one which is in a weird location in CVS. The rest seem to be in Equinox and p2 areas. Any preference where this one should live?
(In reply to comment #6) > (In reply to comment #5) > > > There are a few features that > > > transcend individual components. We already have some of those in the startkit > > > and the equinox.core features. They are in the framework/features folder. I'm > > > fine with that as the spot for "general" features. > > The "general" features are in fact in the components/features folder NOT the > framework/features folder in CVS. That seems like a fine place for high level > features. I agree. (In reply to comment #8) > It looks like the org.eclipse.equinox.sdk feature is the only one which is in a > weird location in CVS. The rest seem to be in Equinox and p2 areas. Any > preference where this one should live? See above :) I think this should go in components/features I must admit I am still confused on the to equinox.core features we have (org.eclipse.equinox.core.sdk and org.eclipse.equinox.core.feature) one or both are poorly named ;-)
Yeah I agree. I think they are just poorly named though and will save that for a different bug report. I've moved the org.eclipse.equinox.sdk project to /cvsroot/rt/org.eclipse.equinox/compontents/features/org.eclipse.equinox.sdk Kim, can you please empty the old location (under org.eclipse.sdk-feature/features) and create a readme file pointing to the new location? Thanks.
done :-)
