Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340443 - Analyze and fix the warnings in the central build
Summary: Analyze and fix the warnings in the central build
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Michael Wenz CLA
QA Contact:
URL:
Whiteboard: Indigo RC1 theme_bugs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 11:40 EDT by Michael Wenz CLA
Modified: 2011-06-24 08:41 EDT (History)
1 user (show)

See Also:
michael.wenz: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Wenz CLA 2011-03-18 11:40:59 EDT
The central build log shows a bunch of warning. Analyze what the reason is and fix them.
Comment 1 Michael Wenz CLA 2011-05-11 03:20:51 EDT
Analysed the warnings in the Hudson build log. Found some that could be fixed but at least the following ones need to be accepted for now:
- No API baseline has been set for any of the plugins. Setting a baseline would introduce errors because of major version has not been incremented and API changes have been done compared to 0.7 (which is ok for a project in incubation)
- Java warnings because of generated classes for metamodel
- Many deprecation that were introduced for Indigo in GEF and Draw2D. Cannot be removed without breaking 3.6 usage possiblity of Graphiti
- Some generics warning (cannot be used because of underlying frameworks not using it)
Comment 2 Michael Wenz CLA 2011-05-11 07:22:02 EDT
The following warnings have been fixed:
- AbstractTracer must not implement ILog (anonymous inner class)
- Some warnings because of broken links, typos and wromg tags in JavaDoc
- Error fetching URL: http://download.oracle.com/javase/6/docs/api/package-list (proxy was missing)

Additionally to the above mentioned, these warnings need to be ignored for now:- Component request org.junit:osgi.bundle/[4.8.2.something] is inconflict with request org.junit:osgi.bundle/[3.8.2.something], because SWTBot enabled both JUnit3 and 4 based tests.
- Lots of warning because referenced EMF and other Eclipse stuff is not found
- Lots of warnings because of non-JavaDoc tags used
  - Eclipse: @noinstantiate, @noextend, @noimplement
  - EMF: @generated, @ordered, @model

The following warnings are completely strange, I have no clue how to fix them. They seem to do no harm, so we also ignore them for now:
- AbstractAddFeature.java:84: cannot find symbol
[ant] symbol  : variable Messages
[ant] location: class org.eclipse.graphiti.features.impl.AbstractAddFeature
[ant] 	private static final String NAME = Messages.AbstractAddFeature_0_xfld;
- AbstractDirectEditingFeature.java:141: cannot find symbol
[ant] symbol  : variable Messages
[ant] location: class org.eclipse.graphiti.features.impl.AbstractDirectEditingFeature
[ant] 	private static final String NAME = Messages.AbstractDirectEditingFeature_0_xfld;
- AbstractUpdateFeature.java:133: cannot find symbol
[ant] symbol  : variable Messages
[ant] location: class org.eclipse.graphiti.features.impl.AbstractUpdateFeature
[ant] 	private static final String NAME = Messages.AbstractUpdateFeature_2_xfld;
- ReconnectionFeatureForPattern.java:33: cannot find symbol
[ant] symbol  : variable Messages
[ant] location: class org.eclipse.graphiti.pattern.ReconnectionFeatureForPattern
[ant] 	private static final String NAME = Messages.ReconnectionFeatureForPattern_0_xfld;

Michael
Comment 3 Michael Wenz CLA 2011-06-24 08:41:35 EDT
Part of Graphiti Indigo 0.8.0