Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340415 - [R4E] Crash after closing / re-opening of a review
Summary: [R4E] Crash after closing / re-opening of a review
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Alvaro Sanchez-Leon CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 07:46 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-01-24 17:33 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-03-18 07:46:58 EDT 
The reference to the group becomes invalid after closing and re-opening of a review, causing  a null pointer exception
Comment 1 Alvaro Sanchez-Leon CLA 2011-03-20 19:09:33 EDT 
The problem was at review closing, the review entry was not removed from the transient list of reviews in the group, 
So when the review was re-opened, EMF would not add it up to the list, since it had an existing entry with the same name (although not valid any more).
So the review was all fine except that it did not have a reference to its parent group (which is taken at the moment it's included in the review list)

So the solution was simply to remove the Review entry in the group during the closing sequence.   

commit b0bda9ca114d5b7abfe35d7bd9046068892937e2
Committer: aleon <alvsan09@gmail.com> 2011-03-18 13:37:37
Comment 2 Steffen Pingel CLA 2011-03-20 21:16:57 EDT 
Reopening to fix assignment.
Comment 3 Steffen Pingel CLA 2011-03-20 21:17:12 EDT 
Closing.