Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340394 - SubmitOperation doesn't need to be multi-threaded
Summary: SubmitOperation doesn't need to be multi-threaded
Status: RESOLVED FIXED
Alias: None
Product: Woolsey
Classification: Technology
Component: IP Log Tool (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 23:13 EDT by Wayne Beaton CLA
Modified: 2011-03-24 13:33 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (7.68 KB, application/octet-stream)
2011-03-24 13:33 EDT, Wayne Beaton CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2011-03-17 23:13:23 EDT 
SubmitOperation uses a job to obtain information. This is unnecessary and adds unneeded complexity (e.g. an observer and instance state management). Instead of using a job, just provide some form of initialization that can be called from the UI components. The UI components can either just wait, or provide their own job to invoke the initialization.
Comment 1 Wayne Beaton CLA 2011-03-24 13:33:28 EDT 
Made initialization run in thread. Now invoking directly from wizard and leveraging wizard's progress bar. Committed, marking as FIXED.
Comment 2 Wayne Beaton CLA 2011-03-24 13:33:29 EDT 
Created attachment 191846 [details]
mylyn/context/zip