Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340358 - Trim can go empty after maximizing a part that was restored after being minimized from a maximized shared area
Summary: Trim can go empty after maximizing a part that was restored after being minim...
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1 RC4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 14:20 EDT by Eric Moffatt CLA
Modified: 2011-06-06 09:59 EDT (History)
1 user (show)

See Also:
remy.suen: review+

Attachments
Remove the 'MAXIMIZED' state from the currently max'd stack (1.57 KB, patch)
2011-05-30 10:14 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-03-17 14:20:21 EDT 
Left over from fixing bug 332498:

- in the Java Perspective
- maximize the editor area
- restore the Package Explorer
- Maximize the PE

You get the same chopped off trim we used to get on a perspective switch
Comment 1 Remy Suen CLA 2011-05-13 14:11:05 EDT 
(In reply to comment #0)
> Left over from fixing bug 332498:
> 
> - in the Java Perspective
> - maximize the editor area
> - restore the Package Explorer
> - Maximize the PE
> 
> You get the same chopped off trim we used to get on a perspective switch

Now the trim on the right disappears for me.

For the general trim clipping problem, see bug 341497.
Comment 2 Eric Moffatt CLA 2011-05-30 10:14:54 EDT 
Created attachment 196902 [details]
Remove the 'MAXIMIZED' state from the currently max'd stack


We do this 'silently' (i.e. without causing an unzoom), then the previously max'd stack gets minimzed normally...
Comment 3 Eric Moffatt CLA 2011-05-30 10:16:22 EDT 
Committed in >20110530. Applied the patch.
Comment 4 Eric Moffatt CLA 2011-05-30 10:29:47 EDT 
Remy, could you take a quick look at the patch ? Feel free to re-open if you don't like it...
Comment 5 Remy Suen CLA 2011-05-30 16:17:15 EDT 
(In reply to comment #4)
> Remy, could you take a quick look at the patch ? Feel free to re-open if you
> don't like it...

Please add a try/finally clause around the true/false switching to ensure that the field gets reset to 'false' even if an exception occurs.

Looks fine to me otherwise.
Comment 6 Eric Moffatt CLA 2011-06-01 15:07:39 EDT 
Done...thanks remy.
Comment 7 Eric Moffatt CLA 2011-06-06 09:59:32 EDT 
Verified in I20110604-2201