Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340295 - [Menu] Fix red Test caused by WRAP implementation for Button
Summary: [Menu] Fix red Test caused by WRAP implementation for Button
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 05:59 EDT by Tim Buschtoens CLA
Modified: 2011-03-17 06:07 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2011-03-17 05:59:11 EDT 
When fixing Bug 325704 i forgot to run tests for Menu (also based on the MultiCellWidget). Tt caused "testMenuResize" to fail. I have not been able to find any problems in a running rap application, but in theory it could menus cause to have the wrong size.
Comment 1 Tim Buschtoens CLA 2011-03-17 06:02:01 EDT 
This is not directly caused by the fix for Bug 325704, but a pre-existing issue that was compensated by the fact that the MCW always re-calculated preferredInnerWidth in its layout. Since this is no longer the case, the cached calue for preferredInnerWidth can end up at null without beeing queued for recomputing. The actual cause is the line "this._invalidateTotalSpacing();" in 
MenuItem#_beforeComputeInnerWidth, which needlessly invalidates the preferredInnerWidth. The bug can be fixed by removeing the line.
Comment 2 Tim Buschtoens CLA 2011-03-17 06:07:32 EDT 
Fixed in CVS HEAD as described above.