Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340273 - Allow wild card search in Open Heap Dump
Summary: Allow wild card search in Open Heap Dump
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-17 02:44 EDT by Pete Robbins CLA
Modified: 2011-04-06 08:06 EDT (History)
1 user (show)

See Also:

Attachments
Patch to add wild card filter (2.69 KB, patch)
2011-03-17 02:45 EDT, Pete Robbins CLA 		andrew_johnson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pete Robbins CLA 2011-03-17 02:44:07 EDT 
Build Identifier: 

Open Heap Dump allows a selection filter on various dump types and "All Know Formats". Some dumps from eg IBM z/OS systems do not conform to any naming pattern so they can not be displayed in the open dialog unless the user renames the dump file to something like .dmp.

I would like to ad an "All Files" filter to the drop down list to act as a *.* search so users can locate and open such files.

Reproducible: Always

Steps to Reproduce:
Use open heap dump as described.
Comment 1 Pete Robbins CLA 2011-03-17 02:45:25 EDT 
Created attachment 191381 [details]
Patch to add wild card filter
Comment 2 Andrew Johnson CLA 2011-03-17 12:26:00 EDT 
The File > Open File... menu does allow a dump to be open with any extension.
Comment 3 Pete Robbins CLA 2011-03-17 12:58:16 EDT 
(In reply to comment #2)
> The File > Open File... menu does allow a dump to be open with any extension.

The MAT perspective does not add the Open File menu item so installing into an eclipse ide or other RCP that does not provide the Open File menu item you can only use open heap dump.

Also Open File will attempt to open the z/OS dump in a text editor which is doomed to failure.

We need a way to say "Open this file. It IS a dump"
Comment 4 Andrew Johnson CLA 2011-03-21 07:14:03 EDT 
Using File > Open File gives

Error
Mon Mar 21 10:10:12 GMT 2011
The file 'P8BUILD.JVM.TDUMP.P8BUILDF.D091127.T103846' could not be opened.See log for details.

Error
Mon Mar 21 10:10:12 GMT 2011
No editor found to edit the file resource.

The patch allows the dump to be opened.


For the record, please could you confirm for the patch:
1.that you wrote 100% of the code
2.that you are authorized to contribute it
3.that is is submitted under the EPL.
This is needed so we can use the patch.
Comment 5 Pete Robbins CLA 2011-03-28 02:31:22 EDT 
I confirm that
1.I wrote 100% of the code
2.I am authorized to contribute it
3.that is is submitted under the EPL.
Comment 6 Andrew Johnson CLA 2011-03-28 11:21:49 EDT 
On Windows XP it is possible to open any file by typing it into the dialog box, and Windows then provides a list of files starting with what has been typed. This is not very convenient if you do not know the name of the file.

This request seems useful, and easier than guessing the start of the file name, so I'll apply the patch.
Comment 7 Andrew Johnson CLA 2011-04-06 08:06:17 EDT 
The patch has now been applied.