Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340262 - [runcontrol][non-stop] Duplicate --thread-group when resuming a process in non-stop and GDB 7.2
Summary: [runcontrol][non-stop] Duplicate --thread-group when resuming a process in no...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 21:34 EDT by Marc Khouzam CLA
Modified: 2011-04-03 23:23 EDT (History)
2 users (show)

See Also:


Attachments
Fix (4.83 KB, patch)
2011-04-03 22:42 EDT, Marc Khouzam CLA
marc.khouzam: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2011-03-16 21:34:13 EDT
With GDB 7.0 and 7.1, not all commands accepted --thread-group.  But, to resume all the threads of a process in non-stop, -exec-continue did accept it, so we added it directly in MIExecContinue.

With GDB 7.2, all commands accept --thread-group and we handle it generically based on the context passed.  This causes a duplication of the flag when resuming the process node in non-stop:

706,816 [MI]  90-exec-continue --thread-group i2 --thread-group i2
706,819 [MI]  90^error,msg="Duplicate '--thread-group' option"

This also applies to MIExecInterrupt.
Comment 1 Marc Khouzam CLA 2011-04-03 22:01:44 EDT
I just noticed that GDB 7.2 is accepting a duplicate --thread-group flag, but that it is GDB 7.2.1 (coming soon to a computer near you) that does not.  But we still have to fix it.
Comment 2 Marc Khouzam CLA 2011-04-03 22:42:35 EDT
Created attachment 192431 [details]
Fix

This fix uses the new GDBRunControl_7_2_NS to no longer force the extra --thread-group flag for -exec-continue and -exec-interrupt.
Comment 3 Marc Khouzam CLA 2011-04-03 22:43:12 EDT
Committed this patch to HEAD.
Comment 4 CDT Genie CLA 2011-04-03 23:23:04 EDT
*** cdt cvs genie on behalf of mkhouzam ***
Bug 340262: Duplicate --thread-group when resuming a process in non-stop and GDB 7.2

[*] GDBRunControl_7_2_NS.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_2_NS.java?root=Tools_Project&r1=1.1&r2=1.2