Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340252 - IllegalArgumentException while hovering over catalog
Summary: IllegalArgumentException while hovering over catalog
Status: RESOLVED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 1.1   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 17:37 EDT by Steffen Pingel CLA
Modified: 2011-04-19 19:36 EDT (History)
0 users

See Also:

Attachments
patch (7.77 KB, patch)
2011-04-08 12:09 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
noiconprovided32.png (512 bytes, image/png)
2011-04-08 12:10 EDT, Benjamin Muskalla CLA 		no flags Details
mylyn/context/zip (66.86 KB, application/octet-stream)
2011-04-08 12:10 EDT, Benjamin Muskalla CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-03-16 17:37:02 EDT 
If a catalog does not specify a description an exception is logged.

java.lang.IllegalArgumentException: Argument cannot be null
	at org.eclipse.swt.SWT.error(SWT.java:4258)
	at org.eclipse.swt.SWT.error(SWT.java:4192)
	at org.eclipse.swt.SWT.error(SWT.java:4163)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:466)
	at org.eclipse.swt.widgets.Label.setText(Label.java:573)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogToolTip.createDescription(CatalogToolTip.java:73)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogToolTip.createToolTipArea(CatalogToolTip.java:65)
	at org.eclipse.equinox.internal.p2.ui.discovery.util.GradientToolTip.createToolTipContentArea(GradientToolTip.java:57)
	at org.eclipse.jface.window.ToolTip.toolTipShow(ToolTip.java:359)
	at org.eclipse.jface.window.ToolTip.toolTipOpen(ToolTip.java:483)
	at org.eclipse.jface.window.ToolTip.toolTipCreate(ToolTip.java:348)
	at org.eclipse.jface.window.ToolTip.access$2(ToolTip.java:342)
	at org.eclipse.jface.window.ToolTip$ToolTipOwnerControlListener.handleEvent(ToolTip.java:631)
Comment 1 Benjamin Muskalla CLA 2011-04-08 12:09:44 EDT 
Created attachment 192853 [details]
patch

Improved error handling for option attribute (icon and description). Will commit once I have commit rights.
Comment 2 Benjamin Muskalla CLA 2011-04-08 12:10:06 EDT 
Created attachment 192854 [details]
noiconprovided32.png

.
Comment 3 Benjamin Muskalla CLA 2011-04-08 12:10:19 EDT 
Created attachment 192855 [details]
mylyn/context/zip
Comment 4 Benjamin Muskalla CLA 2011-04-19 19:36:21 EDT 
Pushed more robust implementation to master, added fallback icon in case a marketplace doesn't provide an icon.