Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340234 - scrollbar in marketplace chooser when selecting solution for install
Summary: scrollbar in marketplace chooser when selecting solution for install
Status: RESOLVED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.1   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 340239 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-16 15:57 EDT by Steffen Pingel CLA
Modified: 2011-05-19 10:01 EDT (History)
1 user (show)

See Also:

Attachments
screenshot (2.20 KB, image/png)
2011-03-16 15:58 EDT, Steffen Pingel CLA 		no flags Details
patch (5.59 KB, patch)
2011-04-13 18:39 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (54.70 KB, application/octet-stream)
2011-04-13 18:39 EDT, Benjamin Muskalla CLA 		no flags Details
patch (5.61 KB, patch)
2011-04-21 12:40 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (7.31 KB, application/octet-stream)
2011-04-21 12:40 EDT, Benjamin Muskalla CLA 		no flags Details
patch (2.62 KB, patch)
2011-05-18 13:52 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (22.10 KB, application/octet-stream)
2011-05-18 13:52 EDT, Benjamin Muskalla CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-03-16 15:57:07 EDT 
The marketplace chooser gets a vertical scrollbar when selection a solution for install which looks a bit odd (screenshot).
Comment 1 Steffen Pingel CLA 2011-03-16 15:58:23 EDT 
Created attachment 191343 [details]
screenshot
Comment 2 Steffen Pingel CLA 2011-03-16 17:48:23 EDT 
*** Bug 340239 has been marked as a duplicate of this bug. ***
Comment 3 Benjamin Muskalla CLA 2011-04-13 18:39:13 EDT 
Created attachment 193204 [details]
patch

Proposed patch, will try again on Windows before commiting
Comment 4 Benjamin Muskalla CLA 2011-04-13 18:39:15 EDT 
Created attachment 193205 [details]
mylyn/context/zip
Comment 5 Benjamin Muskalla CLA 2011-04-21 12:40:07 EDT 
Created attachment 193858 [details]
patch

Suggested patch to force min sizes for the switcher.
Comment 6 Benjamin Muskalla CLA 2011-04-21 12:40:25 EDT 
Created attachment 193859 [details]
mylyn/context/zip
Comment 7 Benjamin Muskalla CLA 2011-04-27 09:59:42 EDT 
Fixed in master.
Comment 8 Steffen Pingel CLA 2011-05-05 12:28:56 EDT 
I now get a scroll bar all the time. Seems scroll by one or two pixels.
Comment 9 Benjamin Muskalla CLA 2011-05-18 13:50:48 EDT 
Doesn't happen with my Ubuntu + GTK, but I see something similar on Vista but with more pixels difference.
Comment 10 Benjamin Muskalla CLA 2011-05-18 13:52:38 EDT 
Created attachment 196024 [details]
patch

Steffen, here is a patch I'll apply for the RC build. In case you have a second, you could try this out if it solves the problem. If this is too much space for your theme/configuration, we'd need to think about a platform-specific solutions as windows often adds some pixels for the layouts from my expierence.
Comment 11 Benjamin Muskalla CLA 2011-05-18 13:52:41 EDT 
Created attachment 196025 [details]
mylyn/context/zip
Comment 12 Benjamin Muskalla CLA 2011-05-18 14:53:44 EDT 
Tested again on Linux, works fine for me.
Released this fix to be part of the RC build today.

Steffen, please test from master/newest release build if you still see scrollbars with these changes.
Comment 13 Steffen Pingel CLA 2011-05-18 16:10:53 EDT 
Looks like that fixed it for me.
Comment 14 Benjamin Muskalla CLA 2011-05-19 10:01:20 EDT 
Great, thanks!