Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340190 - branding of wizard banner is ignored
Summary: branding of wizard banner is ignored
Status: RESOLVED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.1   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 13:06 EDT by Benjamin Muskalla CLA
Modified: 2011-03-16 14:54 EDT (History)
0 users

See Also:

Attachments
patch (1.17 KB, patch)
2011-03-16 13:31 EDT, Benjamin Muskalla CLA 		greensopinion: iplog+
Details | Diff
mylyn/context/zip (2.78 KB, application/octet-stream)
2011-03-16 14:54 EDT, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-03-16 13:06:02 EDT 
It seems the wizard currently ignores the icon branding from the catalogs.
In addition, the current metadata from the server is incorrect. For Eclipse and Yoxos, there is an invalid image url.

Nathan, in the branding section, both marketplaces define "http://marketplace.eclipse.org/" as wizard icon. The API should either return a valid image or return an empty string.
Comment 1 Nathan Gervais CLA 2011-03-16 13:13:15 EDT 
<icon></icon> is now being returned when there is no value.
Comment 2 Benjamin Muskalla CLA 2011-03-16 13:31:24 EDT 
Created attachment 191323 [details]
patch

Thanks Nathan
Comment 3 Benjamin Muskalla CLA 2011-03-16 13:32:02 EDT 
David, see attached patch.
Comment 4 David Green CLA 2011-03-16 14:54:45 EDT 
patch applied, thanks Benjamin
Comment 5 David Green CLA 2011-03-16 14:54:46 EDT 
Created attachment 191334 [details]
mylyn/context/zip