Community
Participate
Working Groups
CQ for JDT project: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4898 JDT bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=336740 JUnit downloads (take 4.8.2, not the 4.9 beta): https://github.com/KentBeck/junit/downloads
Orbit CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5022
The CQ has been approved. I will look at converting the download to a bundle and adding it to Orbit.
The website lists a JAR for 4.8.2 as well as a junit-dep-4.8.2 JAR file. My inclination is to grab the regular JAR but the about.html for 4.8.1 refers to the dep JAR as the binary one. Is that the one I should download? I checked the website and but didn't see a description or list of differences in the two JARs.
Please take the junit-dep-4.8.2.jar. Despite its name, that's actually the one *without* dependencies, i.e. it does not include the org.hamcrest package. junit-4.8.2-src.jar contains the sources (also without hamcrest, which is good).
Ok thanks. I'll try and get this done today so we can get a clean Orbit build with the new JARs asap.
Code released and I kicked off a build. Should be completed in about 2 hours.
Looks good, but in the 2 about.html, you need to keep the <h4>Hamcrest Library 1.1</h4> section. Although we don't mix Hamcrest and JUnit packages into one bundle, the JUnit implementation also copied a few classes from Hamcrest, and therefore, we still need to include that license.
Ok cool, I'll add them back. I wasn't sure because I saw the JUnit bundle require Hamcrest so I thought maybe it used to include them and then we removed them but forgot to update the about previously.
The new JUnit is available in the latest i-build.
2 last problems in the project from CVS: - junit.jar is not exported in .classpath => compile errors in workspace - <name> in .project would better be "org.junit_v4.8.2" (follow pattern from older versions)
Ok cool. Thanks for double-checking the project. I've made those changes in CVS. I won't spin another build since those files aren't shipped with the JAR.
Thanks, CVS looks good now. > I won't spin another build since those files aren't shipped with the JAR. Not directly, but the MANIFEST.MF of org.junit_4.8.2.v4_8_2_v20110321-1705.jar now contains: Eclipse-SourceReferences: scm:cvs:pserver:dev.eclipse.org:/cvsroot/too ls:org.eclipse.orbit/org.junit;tag=v4_8_2_v20110321-1705 So when I try to import that version using PDE's "Import from a repository" feature, I'll get the broken version. I think this is one of the very few moments where moving the v4_8_2_v20110321-1705 tag in CVS to the trunk of the v4_8_2 branch would be safe and the right thing to do.
Don't you ever sleep? :-) Ok, I just moved the tag so the new .classpath and .project files are included.
> Don't you ever sleep? :-) Never ;-) http://xkcd.com/386/ > Ok, I just moved the tag so the new .classpath and .project files are included. Thanks, everything's perfect now.
hehe just got introduced to the humour of xkcd recently. so funny!
