Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340138 - [perf] Huge Performance regression in ApiDescriptionTests#testCleanVisit()
Summary: [perf] Huge Performance regression in ApiDescriptionTests#testCleanVisit()
Status: RESOLVED WORKSFORME
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8   Edit
Assignee: PDE API Tools Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 348419
  Show dependency tree
 
Reported: 2011-03-16 06:49 EDT by Satyam Kandula CLA
Modified: 2012-01-23 15:58 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Satyam Kandula CLA 2011-03-16 06:49:34 EDT
There is around 180% regression in org.eclipse.pde.api.tools.builder.tests.performance.ApiDescriptionTests#testCleanVisit() on a windows machine and looks good on a windows box. This has been around 12th February and somehow, I have missed this.
Comment 1 Curtis Windatt CLA 2011-03-16 12:38:34 EDT
I don't see any changes in API Tools in that timeframe that would cause this.  The test works with the jdt.ui project.
Comment 2 Ankur Sharma CLA 2011-04-19 16:18:57 EDT
I ran this test for M5 and M6 and following were the results after 100 iterations

I20110127-2034 (M5)


  Used Java Heap:         3.92M         (95% in [-33.12M, 40.96M])     Measurable effect: 74.66M (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  Working Set:          459.08K         (95% in [-875.85K, 1.75M])     Measurable effect: 2.63M (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  Committed:            117.84K         (95% in [-1.13M, 1.36M])       Measurable effect: 2.51M (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  Working Set Peak:     521.48K         (95% in [145.43K, 897.53K])    Measurable effect: 758.1K (0.4 SDs) (required sample size for an effect of 5% of stdev: 6401)
  Elapsed Process:         662ms        (95% in [647ms, 678ms])        Measurable effect: 30ms (0.4 SDs)
  Kernel time:              45ms        (95% in [39ms, 50ms])          Measurable effect: 11ms (0.4 SDs) (required sample size for an effect of 5% of mean: 2512)
  Page Faults:            1.22K         (95% in [870, 1.58K])          Measurable effect: 712 (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  CPU Time:                814ms        (95% in [758ms, 870ms])        Measurable effect: 112ms (0.4 SDs) (required sample size for an effect of 5% of mean: 771)
  GDI Objects:               0          (95% in [0, 0])               


I20110310-1119 (M6)


  Used Java Heap:      -620.12K         (95% in [-38.33M, 37.12M])     Measurable effect: 76.05M (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  Working Set:          318.64K         (95% in [-771.21K, 1.38M])     Measurable effect: 2.15M (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  Committed:             39.04K         (95% in [-1,010.91K, 1.06M])   Measurable effect: 2.07M (0.4 SDs) (required sample size for an effect of 5% of stdev: 6401)
  Working Set Peak:     506.64K         (95% in [172.56K, 840.72K])    Measurable effect: 673.48K (0.4 SDs) (required sample size for an effect of 5% of stdev: 6401)
  Elapsed Process:         660ms        (95% in [647ms, 673ms])        Measurable effect: 25ms (0.4 SDs)
  Kernel time:              43ms        (95% in [38ms, 48ms])          Measurable effect: 10ms (0.4 SDs) (required sample size for an effect of 5% of mean: 2395)
  Page Faults:            1.18K         (95% in [881, 1.48K])          Measurable effect: 605 (0.4 SDs) (required sample size for an effect of 5% of stdev: 6400)
  CPU Time:                816ms        (95% in [764ms, 867ms])        Measurable effect: 103ms (0.4 SDs) (required sample size for an effect of 5% of mean: 643)
  GDI Objects:               0          (95% in [0, 0])               



The two results are quite close. I suspect the real reason might be outside API Tools.
Comment 3 Satyam Kandula CLA 2011-04-20 05:01:11 EDT
(In reply to comment #2)
I couldn't reproduce either :(. I tried running the full test suite also but couldn't reproduce.
Comment 4 Michael Rennie CLA 2011-04-20 11:17:19 EDT
I tried running the suites using Windows 7 64bit and also got consistent results (no regression).

Closing as worksforme, since we cannot reproduce the regression.
Comment 5 Michael Rennie CLA 2011-04-20 11:30:34 EDT
reopening, Ankur wants to do some additional investigations.
Comment 6 Ankur Sharma CLA 2011-05-25 01:51:46 EDT
Though we are still pursuing it, there is not much hope for any breakthrough during 3.7
Comment 7 Curtis Windatt CLA 2012-01-23 15:58:27 EST
Returning to WORKSFORME, no additional investigation planned.