Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340136 - [perfs] Performance regression in OpenCloseViewTest#showView:BookmarkView()
Summary: [perfs] Performance regression in OpenCloseViewTest#showView:BookmarkView()
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: performance
Depends on:
Blocks:
 
Reported: 2011-03-16 06:16 EDT by Satyam Kandula CLA
Modified: 2019-11-27 07:07 EST (History)
5 users (show)

See Also:


Attachments
Add degradation comment to the test (1.35 KB, patch)
2011-04-20 15:00 EDT, Oleg Besedin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Satyam Kandula CLA 2011-03-16 06:16:26 EDT
There is a regression in OpenCloseViewTest#showView:BookmarkView(). On one windows machine it is 20% and the other windows machine it is more than 100%. There is no regression on the linux machine.
This seem to have got introduced sometime around 5th March.
Comment 1 Prakash Rangaraj CLA 2011-03-17 04:23:26 EDT
Looking at this.
Comment 2 Oleg Besedin CLA 2011-03-17 11:46:02 EDT
From the test history of I-builds: the 0301 is OK, the 0308 is bad.

This makes the following bugs suspect:

+ Bug 331992. Workspace lock dialog not brought to front
+ Bug 231081. [Markers] Polish Problems view's columns preferences (REOPENED)
+ Bug 283820. [Contexts] NPE on Keys preference page in ContextModel.filterContexts (FIXED)
+ Bug 318914. [WorkingSets] Provide a preference to set size of the list of most recently used working sets (FIXED)
+ Bug 327396. [WorkingSets] updating of working sets during workbench restore can cause loss of working sets (NEW)
+ Bug 333417. [KeyBindings] Rename "Workbench" context and hide if not supported (FIXED)
+ Bug 335308. [JFace] JavaDoc of ControlDecoration#setDescriptionText is wrong (FIXED)
+ Bug 335960. [IDE] Update BuildAction to use new Workspace Build Configurations API (FIXED)
+ Bug 338056. SourceProviders through plugin.xml do not work (FIXED)
+ Bug 338843. Update Display#getAppMenuBar() calls (FIXED)
Comment 3 Prakash Rangaraj CLA 2011-03-31 06:04:17 EDT
Kim,

     How do I get the hardware configurations of the machines on which the performance tests are running?
Comment 4 Kim Moir CLA 2011-03-31 08:36:08 EDT
The machines are all 2 x 3.00GHz machines with 3.00GB of memory.

http://wiki.eclipse.org/Platform-releng-faq#What_hardware_comprises_the_platform-releng_build_infrastructure.3F
Comment 5 Oleg Besedin CLA 2011-04-05 14:09:50 EDT
(In reply to comment #4)
> The machines are all 2 x 3.00GHz machines with 3.00GB of memory.
> 
> http://wiki.eclipse.org/Platform-releng-faq#What_hardware_comprises_the_platform-releng_build_infrastructure.3F

Hmm, so they are identical machines? The link says:

# epwin2 (winxp with 1.5 vm) G on large KVM in rack
# epwin3 (winxp with 1.6 vm) 7 on large KVM in rack 

The test results say:
epwin2: Win XP Sun 1.6.0_17 (2 x 3.00GHz - 3GB RAM)
epwin3: Win XP Sun 1.6.0_17 (2 x 3.00GHz - 3GB RAM)

I am puzzled as to why on two supposedly identical computers (epwin2 and
epwin3) the same test consistently runs 10 times faster on epwin2 vs. epwin3
(~300ms  on epwin2 and ~3.8s on epwin3).
Comment 6 Oleg Besedin CLA 2011-04-05 14:12:35 EDT
By the way, I can not duplicate drop in performance on Windows 7 64bit machine.
Comment 7 Prakash Rangaraj CLA 2011-04-05 14:43:58 EDT
(In reply to comment #6)
> By the way, I can not duplicate drop in performance on Windows 7 64bit machine.

Satyam tried it on his Win XP and he couldn't duplicate that >100% drop either. Whats puzzling stuff is that the BookMarks view is just an another instance of the MarkersView (like Problems View, Tasks View, etc) and there is no regression in them.


The regression started on sometime between Mar 3rd and Mar 5th and there is nothing significant has been checked in: http://download.eclipse.org/eclipse/downloads/drops/I20110329-0800/performance/epwin3/raw/Scenario356.html
Comment 8 Kim Moir CLA 2011-04-05 15:17:57 EDT
Sometimes the machines just need to be rebooted.  I can do that later this week, I'm out of the office right now.
Comment 9 Oleg Besedin CLA 2011-04-19 16:45:19 EDT
I still can't reproduce it. On my Windows 7 machine the timing using the current build is about the same as in 3.6.2. If there is any difference it is less than about 10% and that gets hidden by the test's variability.

Prakash, Satyam, have you being able to reproduce this?
Comment 10 Satyam Kandula CLA 2011-04-20 00:51:59 EDT
(In reply to comment #9)
> I still can't reproduce it. On my Windows 7 machine the timing using the
> current build is about the same as in 3.6.2. If there is any difference it is
> less than about 10% and that gets hidden by the test's variability.
> 
> Prakash, Satyam, have you being able to reproduce this?

I could also see only around 10% regression on Windows XP box.
Comment 11 Oleg Besedin CLA 2011-04-20 15:00:19 EDT
Created attachment 193738 [details]
Add degradation comment to the test

Nobody seems to be able to reproduce the results from the epwin3 test machine. The actual difference between 3.6.2 and current code is less than 10%, if there is any. (For me, at least 1 test group out of 3 is faster on 3.7.)

It is possible that we had two slight performance degradations in 3.7, one on the order of 3% and another on the order of 5%. Due to the high test variability tracing back to the source of those changes is not practical.

I'll add a degradation comment to the test as we are pretty sure those numbers do not indicate real problem. 

I'll keep this bug open so that, time permitting, we can revisit this bug in 3.8.
Comment 12 Oleg Besedin CLA 2011-04-20 15:04:10 EDT
See also bug 343297 .
Comment 13 Lars Vogel CLA 2019-11-27 07:07:11 EST
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.