Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340103 - [assist] FUP of bug 340083
Summary: [assist] FUP of bug 340083
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.8   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 0.8 M7   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 20:31 EDT by Stephan Herrmann CLA
Modified: 2011-04-28 16:51 EDT (History)
0 users

See Also:

Attachments
test & proposed fix (3.90 KB, patch)
2011-04-14 12:17 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-03-15 20:31:33 EDT 
The implementation in bug 340083 still misses one case:
completion after "base." inside a base guard of a
callin binding *with* signatures:
   
    void foo() <- after void foo()
	base when(base.|);

when removing the signatures completion works as intended.
Comment 1 Stephan Herrmann CLA 2011-04-14 12:17:52 EDT 
Created attachment 193274 [details]
test & proposed fix

The fix is simply to avoid overwriting an existing predicate during
syntax recovery. The existing predicate already has the "base" argument
which is required for resolving the "base" reference inside the predicate.
Comment 2 Stephan Herrmann CLA 2011-04-14 12:20:00 EDT 
Released as r1426,7 for 0.8 M7.
Comment 3 Stephan Herrmann CLA 2011-04-28 16:51:52 EDT 
Verified for 0.8M7 using build 201104261158