Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340083 - [assist] cannot complete inside a binding guard
Summary: [assist] cannot complete inside a binding guard
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.8   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 0.8 M6   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 15:46 EDT by Stephan Herrmann CLA
Modified: 2011-03-15 20:32 EDT (History)
0 users

See Also:

Attachments
Test & proposed fix (10.17 KB, patch)
2011-03-15 17:08 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-03-15 15:46:10 EDT 
Given a callin method binding 

   rm <- after bm when (x|);

invoking completion at the indicated location does not produce any proposals.
Comment 1 Stephan Herrmann CLA 2011-03-15 17:08:55 EDT 
Created attachment 191252 [details]
Test & proposed fix

The problem was that the CompletionParser would not recognize the guard
when seeing source only upto the cursor position.

Fixed by adding treatment for guards in checkRecoveredMethodMapping()
(with the help of RecoveredMethodMapping.add(Statement)).
Comment 2 Stephan Herrmann CLA 2011-03-15 17:10:45 EDT 
Committed for 0.8M6 as r1412 / r1413.
Comment 3 Stephan Herrmann CLA 2011-03-15 20:32:50 EDT 
Filed a fup as bug 340103.

Other than that the fix has been verified for 0.8M6 using build 201103151949.