Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 340008 - Consider Window#setExceptionHandler() to have session scope
Summary: Consider Window#setExceptionHandler() to have session scope
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: JFace (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 08:10 EDT by Rüdiger Herrmann CLA
Modified: 2011-03-18 08:41 EDT (History)
2 users (show)

See Also:

Attachments
Session scoped exceptionHandler (2.15 KB, patch)
2011-03-18 06:14 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-03-15 08:10:47 EDT 
Currently the JFace exception handler has application spope (Window#exceptionHandler is a static field).
The way in which it is used by the workbench suggests that it should have session sope (also see bug 340007). In addition, the exception handler having application scope prevents multiple sessions from having different exception handling strageies. Imagine workbench and non-workbench entry points running side by side.
Comment 1 Ivan Furnadjiev CLA 2011-03-18 04:53:22 EDT 
As bug 340007 has been fixed and org.eclipse.ui.internal.ExceptionHandler now has a session scope, we need to take care about Window#exceptionHandler too. It is set in Workbench#runUI().
Comment 2 Ivan Furnadjiev CLA 2011-03-18 06:14:52 EDT 
Created attachment 191495 [details]
Session scoped exceptionHandler
Comment 3 Ivan Furnadjiev CLA 2011-03-18 08:41:37 EDT 
Applied patch to CVS HEAD.