Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339922 - INatTableWidget method isCellSelected should use the plural
Summary: INatTableWidget method isCellSelected should use the plural
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 13:00 EDT by Nicolas Guyomar CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: indigo+


Attachments
Patch for Bug 339922.patch (3.41 KB, patch)
2011-03-14 13:02 EDT, Nicolas Guyomar CLA
gdupe: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-03-14 13:00:37 EDT
Hi,

org.eclipse.emf.facet.widgets.nattable.INatTableWidget.isCellSelected() should be named isCellsSelected(), because it returns whether there is at least one cell selected in the table.

Regards,
Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2011-03-14 13:02:08 EDT
Created attachment 191151 [details]
Patch for Bug 339922.patch

Hi,

Here are the required modifications in INatTableWidget and NatTableWidget classes.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-03-14 13:06:13 EDT
Comment on attachment 191151 [details]
Patch for Bug 339922.patch

Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 398.
Comment 3 Gregoire Dupe CLA 2011-03-14 13:06:57 EDT
This bug can be marked has fixed.

Regards,
Gregoire
Comment 4 Gregoire Dupe CLA 2011-06-08 09:17:28 EDT
This bug can be closed.