Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339881 - [Dev] EMF Facet JUnit tests should not expose any packages
Summary: [Dev] EMF Facet JUnit tests should not expose any packages
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 trivial (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 09:23 EDT by Nicolas Guyomar CLA
Modified: 2020-05-01 11:26 EDT (History)
3 users (show)

See Also:
nicolas.bros: indigo+
gdupe: juno+


Attachments
Patch Bug 339881 (5.99 KB, patch)
2011-03-14 09:35 EDT, Nicolas Guyomar CLA
nicolas.bros: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-03-14 09:23:03 EDT
Hi,

As part of EMF Facet API cleaning, we should put every package in the test layer from public to internal.

Regards,
Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2011-03-14 09:35:12 EDT
Created attachment 191111 [details]
Patch Bug 339881

Hi,

Please find attached the required MANIFEST.MF modification.

Impacted projects are : 

org.eclipse.emf.facet.efacet.catalog.tests
org.eclipse.emf.facet.infra.browser.custom.examples.uml.tests
org.eclipse.emf.facet.infra.browser.custom.tests
org.eclipse.emf.facet.infra.common.core.tests
org.eclipse.emf.facet.infra.facet.tests
org.eclipse.emf.facet.infra.query.tests
org.eclipse.emf.facet.query.java.tests
org.eclipse.emf.facet.util.emf.core.tests
org.eclipse.emf.facet.util.emf.ui.tests
org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 2 Nicolas Bros CLA 2011-03-14 09:38:41 EDT
Committed in revision 390.
Comment 3 Gregoire Dupe CLA 2011-06-07 12:20:21 EDT
The following packages are still exposed:
 - org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm.sample,
 - org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm.sample.class1,
 - org.eclipse.emf.facet.widgets.nattable.tests.bug344563.internal.bug344563,
 - org.eclipse.emf.facet.widgets.nattable.tests.bug344563.internal.bug344563.impl,
 - org.eclipse.emf.facet.widgets.nattable.tests.bug344563.internal.bug344563.util
Comment 4 Gregoire Dupe CLA 2012-05-23 12:29:32 EDT
This bug has to be closed for the IP log.