Community
Participate
Working Groups
Hello, Some use cases require to be able to edit derived facet attribute and derived facet references. To satisfy this requirement we have to modify the facet metamodel to add a "set" query on derived structural features. This has to be done before the API freeze. Regards, Gregoire Dupe
I’ve committed the meta-model modification. (Committed revision 391) I've added the operation org.eclipse.emf.facet.infra.facet.core.FacetContext.set(EObject, EStructuralFeature, Object). (Committed revision 392) Next step: implementation. Regards, Gregoire Dupe
Created attachment 192618 [details] Patch for Bug 339880 Hi, Please find attached the implementation of the method FacetContext.set(...) In order to be able to use this method, I had to remove some validation rules in plug-in org.eclipse.emf.facet.infra.facet. A facet can now be derived and changeable. I've added IJavaModelQueryWithEditingDomain in the validation process, so that the builder does not add error marker on the SetQuery with an editingDomain I've also regenerated the org.eclipse.emf.facet.infra.facet.edit and org.eclipse.emf.facet.infra.facet.editor plug-ins so that we can set the newly added setQuery. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 192619 [details] Patch for Bug 339880 Unit test Hi, Please find attached a first JUnit Test for the new implementation of FacetContext.set(...) method. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 192618 [details] Patch for Bug 339880 Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 497.
Comment on attachment 192619 [details] Patch for Bug 339880 Unit test Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 497.
This bug can be marked as fixed.
Created attachment 192938 [details] Patch for Bug 339880 Facet Editor Hi, Since this evolution was made, we should be able to set the newly added "SetQuery" through the Facet Editor. Here is a patch which modify the editor properties view. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 192938 [details] Patch for Bug 339880 Facet Editor Here is a contribution from one employee of Mia-Software, targeting future Indigo release. The company has signed a Member Commiter Agreement. The contribution does not need a CQ (see bug 322327). I've committed this contribution. Committed revision 510.
This bug can be closed.
