Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339876 - Renaming side effect on org.eclipse.emf.facet.infra.common.ui
Summary: Renaming side effect on org.eclipse.emf.facet.infra.common.ui
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 08:32 EDT by Nicolas Guyomar CLA
Modified: 2020-05-01 11:26 EDT (History)
3 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Patch for Bug 339876 (3.81 KB, patch)
2011-03-14 08:35 EDT, Nicolas Guyomar CLA 		no flags Details | Diff
Patch Bug 339876 (1.65 KB, patch)
2011-03-14 09:06 EDT, Nicolas Guyomar CLA 		nicolas.bros: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-03-14 08:32:30 EDT 
Hi,

When we copied MoDisco infra layer to EMF Facet project, we updated an image name which had not to be change.

icons\logoMoDiscoMini.gif is referenced as org.eclipse.emf.facet.infra.common.ui.internal.util.ImageProvider.EMFFACET_LOGO

It should stay MODISCO_LOGO, with the accurate URI

Regards,
Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2011-03-14 08:35:03 EDT 
Created attachment 191104 [details]
Patch for Bug 339876

Hi,

In the attached patch I did the required renaming of ImageProvider.EMFFACET_LOGO for ImageProvider.MODISCO_LOGO and updated the URI.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 2 Nicolas Guyomar CLA 2011-03-14 09:06:20 EDT 
Created attachment 191110 [details]
Patch Bug 339876

Updated patch

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 3 Nicolas Bros CLA 2011-03-14 09:08:58 EDT 
Committed in revision 387.
Comment 4 Gregoire Dupe CLA 2011-06-07 12:36:19 EDT 
Comment on attachment 191110 [details]
Patch Bug 339876

Here is patch smaller than 250 lines (38 lines), no CQ is then needed.
Comment 5 Gregoire Dupe CLA 2011-06-07 12:36:54 EDT 
This bug can be closed.