Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339855 - ModelCellEditor class should not be exposed
Summary: ModelCellEditor class should not be exposed
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 05:58 EDT by Nicolas Guyomar CLA
Modified: 2020-05-01 11:27 EDT (History)
3 users (show)

See Also:
nicolas.bros: indigo+

Attachments
patch (17.16 KB, patch)
2011-03-14 06:29 EDT, Nicolas Bros CLA 		nicolas.bros: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-03-14 05:58:19 EDT 
Hi,

As part of the EMF Facet API clean, we should not expose the class ModelCellEditor in plug-in org.eclipse.emf.facet.widgets.celleditors

Regards,
Nicolas Guyomar
Comment 1 Nicolas Bros CLA 2011-03-14 06:29:08 EDT 
Created attachment 191097 [details]
patch
Comment 2 Nicolas Bros CLA 2011-03-14 06:59:38 EDT 
Committed in revision 385.
Comment 3 Nicolas Bros CLA 2011-03-14 07:37:16 EDT 
What the patch does:

In ICellEditorsRegistry the method getCellEditorFor(EClassifier type, final boolean many) returned an instance of ModelCellEditor, which was not meant to be API. So, I refactored it into two new methods: getCellEditorFor which returns an IModelCellEditor (which is API) and getNaryCellEditorFor that returns a INaryFeatureCellEditor (which is API too).

As well, I replaced the 2nd override of getCellEditorFor that takes a list of preferred cell editors by two new methods in the same way.

Now, CellEditorsRegistry implements the new version of the interface, but still exposes the old API for internal use in EMF Facet through 2 new getCellEditorWrapperFor methods.

The rest of the changes are to adapt parts of EMF Facet to this new API.
Comment 4 Gregoire Dupe CLA 2011-06-07 12:14:13 EDT 
This bug can be closed.