Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339771 - Split WTP-specific schema type provider into separate plugin (plus test plugin)
Summary: Split WTP-specific schema type provider into separate plugin (plus test plugin)
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xpath (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Jesper Moller CLA
QA Contact: Jesper Moller CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 18:13 EST by Jesper Moller CLA
Modified: 2011-04-28 22:10 EDT (History)
1 user (show)

See Also:
david_williams: pmc_approved+
david_williams: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Moller CLA 2011-03-11 18:13:54 EST
The split of org.eclipse.wst.xml.xpath2.wtptypes from org.eclipse.wst.xml.xpath2.processor didn't make it into M6. It is in CVS and builds with Hudson+Tycho, but hasn't been released to the map files yet.
I would like to crate the bundle 'org.eclipse.wst.xml.xpath2.wtptypes' (and an associated test bundle) and add this as a dependency in org.eclipse.wst.xml.xpath.core.

Marking this as an exception as I guess as it is a bundle change, awaiting PMC approval and M6 I-build promotion to Indigo site on March 15th.
Comment 1 Jesper Moller CLA 2011-03-11 18:17:21 EST
Review or approval, I don't know, I just don't want to cause problems.
Comment 2 David Williams CLA 2011-03-15 00:54:44 EDT
I'm fine with this. Thanks for keeping us informed. But ... can you summarize what "wtptypes" is? Why splitting? How might adopters be effected? I assume all is still contained in one feature, and this split is for those where users use the xpath2 processor as a 'standalone' jar? 

Thanks.
Comment 3 Jesper Moller CLA 2011-03-15 05:13:02 EDT
(In reply to comment #2)
> I'm fine with this. Thanks for keeping us informed. But ... can you summarize
> what "wtptypes" is? Why splitting? How might adopters be effected? I assume all
> is still contained in one feature, and this split is for those where users use
> the xpath2 processor as a 'standalone' jar? 
> 
> Thanks.

Yes, the split is exactly to reduce coupling.
The "wtptypes" code is an implementation on the XPath2 "TypeModel"-interface against the SSE+XSD type model. It is also useful in the XSL plugin, and for other potential adopters (XQuery development tools might find it useful, too)

"wtptypes" was the best name I could come up with to signify that it was not just XSD model specific, since it depends on SSE/XML too. Suggestions for a better name are welcome!

If the introduction of an extra bundle is an issue (I guess there's a memory and start-up overhead), we could move the code into org.eclipse.wst.xml.xpath.core bundle, which is the non-UI part of the XPath view - it does contain some extra stuff and dependencies, but it is very small.

How big is the extra overhead of adding one additional bundle, runtime-wise?
Comment 4 David Williams CLA 2011-03-15 08:19:46 EDT
> 
> How big is the extra overhead of adding one additional bundle, runtime-wise?

It is not much as long as there is no "startup" code, and as long as the bundle is 'jarred'. If the code is in its own distinct package (namespace) then probably best to have/leave in distinct bundle.
Comment 5 Jesper Moller CLA 2011-04-20 01:36:03 EDT
This one is fixed in M7, resolving.