Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339698 - [server] We should not keep the state in servlets
Summary: [server] We should not keep the state in servlets
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 09:32 EST by Szymon Brandys CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-03-11 09:32:49 EST 
I noticed that in some places we keep states in servlets or handlers used by servlets. For instance:
GitIndexHandlerV1 has a private Repository db field, which is set by #handleRequest and reuse later. Since our servlets along with handlers are singletons this is a potential threat.
Comment 1 Tomasz Zarna CLA 2011-03-14 07:14:57 EDT 
Fixed with 555fd0d6cb28ba9d4dcdadf05ae489455db6b1a2.