Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339640 - XtextResourceSetProvider no longer permits a null project
Summary: XtextResourceSetProvider no longer permits a null project
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 344388 (view as bug list)
Depends on:
Blocks: 303977
  Show dependency tree
 
Reported: 2011-03-11 01:38 EST by Ed Willink CLA
Modified: 2017-09-19 17:50 EDT (History)
3 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-03-11 01:38:44 EST 
2.0M5 almost M6.

XtextResourceSetProvider.get(IProject) used to tolerate a null project for non-project contexts such as views as used by the XTFO EmbeddedXtextEditor.

This now NPEs. The following lines

IJavaProject javaProject = JavaCore.create(project);
set.getURIConverter().getURIMap().putAll(computePlatformURIMap(javaProject));
if (javaProject!=null && javaProject.exists()) {

demonstrate that a null javaProject was once permitted.
Comment 1 Michael Clay CLA 2011-03-15 18:22:07 EDT 
which also affects return resourceSetProvider.get(null); in ResourceForIEditorInputFactory
Comment 2 Sebastian Zarnekow CLA 2011-03-20 14:39:32 EDT 
Pushed to master.
Comment 3 Sebastian Zarnekow CLA 2011-05-01 03:48:49 EDT 
*** Bug 344388 has been marked as a duplicate of this bug. ***
Comment 4 Karsten Thoms CLA 2017-09-19 17:38:56 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 17:50:08 EDT 
Closing all bugs that were set to RESOLVED before Neon.0