Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339639 - [builder] QueuedBuildData#queueURI(URI) should be public
Summary: [builder] QueuedBuildData#queueURI(URI) should be public
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 339638 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-11 01:25 EST by Knut Wannheden CLA
Modified: 2017-09-19 17:24 EDT (History)
1 user (show)

See Also:
sven.efftinge: indigo+

Attachments
patch for QueuedBuildData (1.95 KB, patch)
2011-03-11 01:25 EST, Knut Wannheden CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wannheden CLA 2011-03-11 01:25:33 EST 
The method QueuedBuildData#queueURI(URI) is currently declared with package level visibility. I think it should be changed to public to allow subclassing in order to provide custom build ordering algorithms.
Comment 1 Knut Wannheden CLA 2011-03-11 01:25:59 EST 
Created attachment 190956 [details]
patch for QueuedBuildData
Comment 2 Sven Efftinge CLA 2011-03-26 15:06:57 EDT 
*** Bug 339638 has been marked as a duplicate of this bug. ***
Comment 3 Sven Efftinge CLA 2011-03-26 15:09:25 EDT 
marking it 'protected' should be sufficient to allow for subclassing.
Comment 4 Knut Wannheden CLA 2011-03-27 03:36:49 EDT 
Since the method is also called from within the BuildData class I think public would make sense here.
Comment 5 Sven Efftinge CLA 2011-03-29 00:19:27 EDT 
pushed to master
Comment 6 Karsten Thoms CLA 2017-09-19 17:12:32 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 7 Karsten Thoms CLA 2017-09-19 17:24:07 EDT 
Closing all bugs that were set to RESOLVED before Neon.0