Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339592 - [client] get rid of soria dojo theme
Summary: [client] get rid of soria dojo theme
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 15:42 EST by Susan McCourt CLA
Modified: 2011-09-01 11:41 EDT (History)
2 users (show)

See Also:


Attachments
"nihilo" in the header (4.70 KB, image/png)
2011-03-23 05:22 EDT, Malgorzata Janczarska CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-03-10 15:42:05 EST
for M6 I restyled selective parts of dojo to get rid of the soria blue.  We should punt the soria style completely and see what "unthemed" styles look like.  Then we could selectively add styling that matches our skinning rather than overriding all that soria blue.
Comment 1 Susan McCourt CLA 2011-03-22 13:09:07 EDT
I tried running without a dojo theme.  It doesn't work because you end up with widgets that have no borders and no uniform spacing.  So we do need to pick a theme.  After running the theme tester, I decided that "nihilo" seems the most neutral.  We still need to override some theme settings for things like:
- custom splitter
- menus whose backgrounds match our colors
- custom hover colors, etc.
Comment 2 Susan McCourt CLA 2011-03-22 13:13:27 EDT
fixed.
There is still some style tweaking to do (in places where we had the blue before, we might have some less than optimal styling, such as grid headings, etc.)

Andrew - since we are changing which dojo stylesheets are being used, do we need to change anything about the built dojo?
Comment 3 Andrew Niefer CLA 2011-03-22 13:18:12 EDT
Our built dojo layer is only javascript, I don't think we need to do anything there to switch the css being used
Comment 4 Malgorzata Janczarska CLA 2011-03-23 05:22:50 EDT
Created attachment 191734 [details]
"nihilo" in the header

I don't know where it came from, but in git-log.html I'm getting the sign "nihilo" on the top. Isn't  "nihilo", the name of the new class?
Comment 5 Susan McCourt CLA 2011-03-23 12:57:58 EDT
(In reply to comment #4)
> Created attachment 191734 [details]
> "nihilo" in the header
> 
> I don't know where it came from, but in git-log.html I'm getting the sign
> "nihilo" on the top. Isn't  "nihilo", the name of the new class?

sorry about that.  I must have had an errant paste when I was manually checking the changes.  Fixed.